Open
Conversation
* Bump axios from 1.11.0 to 1.13.2 (#2368) Bumps [axios](https://github.com/axios/axios) from 1.11.0 to 1.13.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.11.0...v1.13.2) --- updated-dependencies: - dependency-name: axios dependency-version: 1.13.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump webpack-dev-server from 5.1.0 to 5.2.1 (#2367) Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 5.1.0 to 5.2.1. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v5.1.0...v5.2.1) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-version: 5.2.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump js-yaml from 4.1.0 to 4.1.1 (#2384) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Feature/collectibles home tab (#2405) * Feature/move icons to own hook (#2308) * move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments * [FEATURE] adds send and swap buttons to asset detail view (#2351) * adds send and swap buttons to asset detail view * uses secondary button styles * removes run snapshots job (#2355) * release/5.35.4 (#2354) * upgrade to ledger-hq/hw-transport-webhid (#2350) * upgrade to ledger-hq/hw-transport-webhid * add tests * add ledger support for new trustline flow (#2352) * upgrade to ledger-hq/hw-transport-webhid * add ledger support for new trustline flow * only re-fetch balances if we were successful * test for fetching balances on success * add reset spys * adjust spacing at top of hw wallet modal * Now that `Done` button properly shows, click it in tests (#2356) * skip flakey test * skip flakey test * renames local vars to follow convention * adds tests for LP share and tweaks LP title * adds links with query params for asset detail CTAs --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com> * first pass at showing collectibles in UI * add metadata fetching * add tests for metadata * check for owner of collectibles and test * add empty placeholder and add comments; rm placeholder values * rm captureException * rm duplicated tests added by rebase * pr comments * make non-square nft's cover; only show `collectibles` tab on non-custom network * attempt to clean up flakey e2e tests * rollback parallel testing * removing testing data * update tests --------- Co-authored-by: aristides <aristides.staffieri@stellar.org> * Feature/add collectibles (#2423) * Add Collectible UI * add localstorage and caching; add tests * add clipboardRead access for extension * rm consoles and add screenshot * rm console log * PR comments * fix conflict from rebase * fix typo; rm console.log * rename ManageCollectibles to AddCollectibles; finish `collectibleContractAddress` rename * fix tests * fix e2e test * update placeholder string * [BUG] fixes settings state persistence for asset selection in send and swap flows (#2420) * fixes settings state persistence for asset selection in send and swap flows * simplifies selection logic in e2e tests * tweaks role selector for test btn * adds mocks to new send payment tests for common api paths * uses correct login method for new test cases * fixes back button locators across all new tests, tweaks selector for final default state assertions * resets asset selection only on exit of send flow * adjust send payment settings e2e tests for correct state after asset navigation * Add memo-required flows for Dapp + Normal send (#2400) * Feature/move history fetch to bg (#2273) * upgrade to yarn 2 and use resolutions to block vulnerable package versions (#2239) * upgrade to yarn 2 and use resolutions to block vulnerable package versions * rm deprecated .yarnrc * rm yarnpath * try committing yarn binary to repo * try corepack enable for gha * update run tests cmd * rm yarnpath * rm npm i yarn * update all pipelines * rm superfluous history types * ensure invoke host function tx shows contract parameters (#2243) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * Bugfix/rm auth param names (#2244) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op (#2246) * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * Revert "add issuer for changeTrust op (#2246)" (#2247) This reverts commit 19c8a68. * Bugfix/add issuer for changetrust (#2249) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * cache account balances and poll for updates * fix CI tests * rm `force:true` which was causing action to happen too fast * do a fresh balance fetch on account/network change * first pass at async history * pr comments * allow for history caching * add more sentry tracking for Account and Wallets views (#2268) * add more sentry tracking for Account and Wallets views * adding more sentry reporting * gracefully degrade on errors from Blockaid (#2269) * gracefully degrade on errors from Blockaid * should not be necessary to skip dapp scanning on custom network * rm extra dep * add a test for persisting configurations in the send flow (#2271) * add a test for persisting configurations in the send flow * rm logs and update muxed acct; lower xlm payment * rm slow loading simulation * handle missing scan-tx result; add disabled state for Confirm Anyway (#2272) * handle missing scan-tx result; add disabled state for Confirm Anyway * assertions to show correct confirm button on Blockaid error * add cache for balances to ensure we do a fresh lookup when needed (#2275) * add cache for balances to ensure we do a fresh lookup when needed * add try...catch to token-prices polling * rm log * only dispatch saveBalancesForAccount when fresh data has been fetched * adjust test to wait for UI change * replace yarn setup with just yarn * rm unnecessary return * clear token details on redux clear action * make history row construction async and check for redux state for updates * add tests for assetdetails * increase timeout for flakey test * pr comments * refresh account history every time account balances refresh * check for updated appdata before showing password modal (#2300) * check for updated appdata before showing password modal * update error msg * rm unused redirect logic * stringify errors rather than using `cause` (#2302) * Feature/move icons to own hook (#2308) * move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments * skip blockaid scan on first fetch of account-balances (#2310) * skip blockaid scan on first fetch of account-balances * rm stub change * rm more stubs * rm log * add comments and update boolean naming * Dropdown menu option to copy wallet address (#2316) * add button to copy address from dropdown * Added translations * revert translation file changes * revert translation file changes * Added translations * revert changes to translation files * move copy address button to first dropdown position * scroll on long strings; pretty print json (#2320) * scroll on long strings; pretty print json * rm log * add correct snapshot for json message * rm log * finish comment * add error case for JSON * don't use carat for lib * update yarn.lock * move scrollbar to btm of container; reduce json font size * update snapshot * re-searching so should abort any in flight API requests (#2323) * re-searching so should abort any in flight API requests * add comment * fix test name * make test more reliable * add check for correct search results * fix jest locator * [FEATURE] new send/swap navigation flow (#2353) * adds SelectionTile and AddressTile, updates nav flows to match updates. Adds query parameter for default values in send flow * Added translations * adds address tile and uses it in swap flow, tweaks selection tile styles * adds unit tests for new tile components * Added translations * updates swap navigation flow to match updates, updates tests flows to match * updates back icon for send and swap steps, fixes bad test references * tweaks locator in address tile tests * adds store state to asset tile tests, removes asset icon mock * updates SelectionTile prop name, adds isSuspicious prop for AssetTile * adds placeholder value in TokenList for missing token USD value * uses real IdenticonImg in address tile unit tests * adds query param validation for send and swap flow * Update extension/src/popup/views/SendPayment/index.tsx Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * adds missing import * adds class for tile icon --------- Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * [FEATURE] adds send and swap buttons to asset detail view (#2351) * adds send and swap buttons to asset detail view * uses secondary button styles * removes run snapshots job (#2355) * release/5.35.4 (#2354) * upgrade to ledger-hq/hw-transport-webhid (#2350) * upgrade to ledger-hq/hw-transport-webhid * add tests * add ledger support for new trustline flow (#2352) * upgrade to ledger-hq/hw-transport-webhid * add ledger support for new trustline flow * only re-fetch balances if we were successful * test for fetching balances on success * add reset spys * adjust spacing at top of hw wallet modal * Now that `Done` button properly shows, click it in tests (#2356) * skip flakey test * skip flakey test * renames local vars to follow convention * adds tests for LP share and tweaks LP title * adds links with query params for asset detail CTAs --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com> * only fetch asset list data if needed (#2369) * only fetch asset list data if needed * correctly show icon loading state * [BUG] SAC token management improvements (#2374) * adds SAC detection when changing trust in the add and remove token flows * updates arg signature for isAssetSac * Feature/cache token prices (#2373) * cache token prices and batch loading wallets * use similar methodology for token price and account balance caching * fix loading state trigger * fix tests * use helper for cache clearing * set isFetchingTokenPrices to false in catch handler * rollback error change * load backend settings async on Account view (#2381) * load backend settings async on Account view * rm console.logs * Feature/use ledger key for home domains (#2363) * use ledger-key/accounts endpoint for home domains * fix tests * create generic ledger key account helper; add tests * rm unneeded data-test prop * rm unused import * [CHORE] git process updates (#2361) * moves the add translations hook to the pre commit stage, removes standalone translations commit * adds script to update app version, removes version update from submit production action, adds update version step to test run action for release branches * removes version input, now uses package version * fetch asset domains in one calls * fix tests * cache home domains while iterating over account history rows * fitler non-G keys * rm .only * fix test param * PR comments --------- Co-authored-by: aristides <aristides.staffieri@stellar.org> * update version numbers for release * rm unnecessary calls to make flows even faster (#2391) * makes send swap buttons stay in the container in full screen mode (#2392) * makes send swap buttons stay in the container in full screen mode * add a pause to make sure flakey e2e test has time to save changes * add v1 of memo-required flow for transaction confirmation * adjust memo required flow for dapp and tx rebuild * add memo max bytes error handling * update transaction loose text strings * update transaction loose text strings * update tranlation with uppercase * fix transaction fee setting * adjust memo required on revalidation and add a container for message * update memo-required flow to slide from right * update translation keys and memo required panes * use redux selector for allAccounts to properly update rename (#2403) * use redux selector for allAccounts to properly update rename * add longer timeout for flakey btn * fix unit tests * revert test case change * adjust sending user back to review sheet on add memo only * add e2e tests for memo required flows * fix add memo back and forth test * simplify comments and logic for memo required check --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: aristides <aristides.staffieri@stellar.org> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * Update PT Translations and usage (#2404) * Feature/move history fetch to bg (#2273) * upgrade to yarn 2 and use resolutions to block vulnerable package versions (#2239) * upgrade to yarn 2 and use resolutions to block vulnerable package versions * rm deprecated .yarnrc * rm yarnpath * try committing yarn binary to repo * try corepack enable for gha * update run tests cmd * rm yarnpath * rm npm i yarn * update all pipelines * rm superfluous history types * ensure invoke host function tx shows contract parameters (#2243) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * Bugfix/rm auth param names (#2244) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op (#2246) * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * Revert "add issuer for changeTrust op (#2246)" (#2247) This reverts commit 19c8a68. * Bugfix/add issuer for changetrust (#2249) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * cache account balances and poll for updates * fix CI tests * rm `force:true` which was causing action to happen too fast * do a fresh balance fetch on account/network change * first pass at async history * pr comments * allow for history caching * add more sentry tracking for Account and Wallets views (#2268) * add more sentry tracking for Account and Wallets views * adding more sentry reporting * gracefully degrade on errors from Blockaid (#2269) * gracefully degrade on errors from Blockaid * should not be necessary to skip dapp scanning on custom network * rm extra dep * add a test for persisting configurations in the send flow (#2271) * add a test for persisting configurations in the send flow * rm logs and update muxed acct; lower xlm payment * rm slow loading simulation * handle missing scan-tx result; add disabled state for Confirm Anyway (#2272) * handle missing scan-tx result; add disabled state for Confirm Anyway * assertions to show correct confirm button on Blockaid error * add cache for balances to ensure we do a fresh lookup when needed (#2275) * add cache for balances to ensure we do a fresh lookup when needed * add try...catch to token-prices polling * rm log * only dispatch saveBalancesForAccount when fresh data has been fetched * adjust test to wait for UI change * replace yarn setup with just yarn * rm unnecessary return * clear token details on redux clear action * make history row construction async and check for redux state for updates * add tests for assetdetails * increase timeout for flakey test * pr comments * refresh account history every time account balances refresh * check for updated appdata before showing password modal (#2300) * check for updated appdata before showing password modal * update error msg * rm unused redirect logic * stringify errors rather than using `cause` (#2302) * Feature/move icons to own hook (#2308) * move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments * skip blockaid scan on first fetch of account-balances (#2310) * skip blockaid scan on first fetch of account-balances * rm stub change * rm more stubs * rm log * add comments and update boolean naming * Dropdown menu option to copy wallet address (#2316) * add button to copy address from dropdown * Added translations * revert translation file changes * revert translation file changes * Added translations * revert changes to translation files * move copy address button to first dropdown position * scroll on long strings; pretty print json (#2320) * scroll on long strings; pretty print json * rm log * add correct snapshot for json message * rm log * finish comment * add error case for JSON * don't use carat for lib * update yarn.lock * move scrollbar to btm of container; reduce json font size * update snapshot * re-searching so should abort any in flight API requests (#2323) * re-searching so should abort any in flight API requests * add comment * fix test name * make test more reliable * add check for correct search results * fix jest locator * [FEATURE] new send/swap navigation flow (#2353) * adds SelectionTile and AddressTile, updates nav flows to match updates. Adds query parameter for default values in send flow * Added translations * adds address tile and uses it in swap flow, tweaks selection tile styles * adds unit tests for new tile components * Added translations * updates swap navigation flow to match updates, updates tests flows to match * updates back icon for send and swap steps, fixes bad test references * tweaks locator in address tile tests * adds store state to asset tile tests, removes asset icon mock * updates SelectionTile prop name, adds isSuspicious prop for AssetTile * adds placeholder value in TokenList for missing token USD value * uses real IdenticonImg in address tile unit tests * adds query param validation for send and swap flow * Update extension/src/popup/views/SendPayment/index.tsx Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * adds missing import * adds class for tile icon --------- Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * [FEATURE] adds send and swap buttons to asset detail view (#2351) * adds send and swap buttons to asset detail view * uses secondary button styles * removes run snapshots job (#2355) * release/5.35.4 (#2354) * upgrade to ledger-hq/hw-transport-webhid (#2350) * upgrade to ledger-hq/hw-transport-webhid * add tests * add ledger support for new trustline flow (#2352) * upgrade to ledger-hq/hw-transport-webhid * add ledger support for new trustline flow * only re-fetch balances if we were successful * test for fetching balances on success * add reset spys * adjust spacing at top of hw wallet modal * Now that `Done` button properly shows, click it in tests (#2356) * skip flakey test * skip flakey test * renames local vars to follow convention * adds tests for LP share and tweaks LP title * adds links with query params for asset detail CTAs --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com> * only fetch asset list data if needed (#2369) * only fetch asset list data if needed * correctly show icon loading state * [BUG] SAC token management improvements (#2374) * adds SAC detection when changing trust in the add and remove token flows * updates arg signature for isAssetSac * Feature/cache token prices (#2373) * cache token prices and batch loading wallets * use similar methodology for token price and account balance caching * fix loading state trigger * fix tests * use helper for cache clearing * set isFetchingTokenPrices to false in catch handler * rollback error change * load backend settings async on Account view (#2381) * load backend settings async on Account view * rm console.logs * Feature/use ledger key for home domains (#2363) * use ledger-key/accounts endpoint for home domains * fix tests * create generic ledger key account helper; add tests * rm unneeded data-test prop * rm unused import * [CHORE] git process updates (#2361) * moves the add translations hook to the pre commit stage, removes standalone translations commit * adds script to update app version, removes version update from submit production action, adds update version step to test run action for release branches * removes version input, now uses package version * fetch asset domains in one calls * fix tests * cache home domains while iterating over account history rows * fitler non-G keys * rm .only * fix test param * PR comments --------- Co-authored-by: aristides <aristides.staffieri@stellar.org> * update version numbers for release * rm unnecessary calls to make flows even faster (#2391) * makes send swap buttons stay in the container in full screen mode (#2392) * makes send swap buttons stay in the container in full screen mode * add a pause to make sure flakey e2e test has time to save changes * add v1 of memo-required flow for transaction confirmation * adjust memo required flow for dapp and tx rebuild * add memo max bytes error handling * update transaction loose text strings * update transaction loose text strings * update tranlation with uppercase * fix transaction fee setting * adjust memo required on revalidation and add a container for message * update memo-required flow to slide from right * update translation keys and memo required panes * use redux selector for allAccounts to properly update rename (#2403) * use redux selector for allAccounts to properly update rename * add longer timeout for flakey btn * add portuguese missing translations * adjust still missing PT translations * update last mismatching translation keys * add one more set of missing translations * extra set of missing function translations * extra set of missing function translations * extra set of missing function translations * fix unit tests * update e2e tests * delete unused files * add one more set of missing translations * add hwconnect, soroban and error translations * replace usage of curly quotes with normal quotes * break down long translation keys * remove pending duoplicate keys * fix nested translation keys * add translation for congestion * remove nested translation keys * remove nested translation keys * remove nested translation keys * adjust nested files and revert prettier config * adjust nested files and revert prettier config * adjust missing fee translation * remove duplicated keys * prevent webpack from removing translations * prevent webpack from removing translations * replace strings with interpolation * add back memo flow and update missing string interpolations * remove Address.json and interpolate keys * remove address.json * preserve translation namespaces * remove auto creation of address.json * prevent address namespace creation * fix failing tests cases * revert changes to sendPayment flow * adjust language setting on test fixtures * update account unfunded flaky test * revert test case change * adjust sending user back to review sheet on add memo only * add e2e tests for memo required flows * fix add memo back and forth test * merge base into branch * partial revert changes to tests * revert changes unrelated to translation on tests * revert changes unrelated to translations * remove custom logic from i18n webpack * remove interpolated forced spacing * simplify interpolated strings * add missing PT translations and smoke tests * adjust casing for unified translations * revert quotes back to curly quotes * simplify test fixtures for PT lang * revert quotes back to curly quotes * replace string concatenations with interpolation * revert strings to old forms with translation --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: aristides <aristides.staffieri@stellar.org> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * Feature/collectible detail (#2451) * add CollectibleDetail UI * add popover and tests * adds additional testing * fetch only the metadata for the current detail * use state from hook * fix missing translations helpers * rm log * fix tests * test failing due to copy change * rm empty dir and fix test due to copy change * add shadcn sheet and use on asset/collectible detail (#2463) * Bump mdast-util-to-hast from 13.2.0 to 13.2.1 (#2421) Bumps [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) from 13.2.0 to 13.2.1. - [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases) - [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1) --- updated-dependencies: - dependency-name: mdast-util-to-hast dependency-version: 13.2.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add collectibles to the Send flow * Revert "add collectibles to the Send flow" This reverts commit 175b086. * Add collectibles to send flow (#2473) * Reapply "add collectibles to the Send flow" This reverts commit be2a075. * fix incorrect fee * code cleanup * pr comments * check for found collectible * add unit tests * [CHORE] upgrades stellar sdk to latest version (#2480) * upgrades stellar sdk to latest version * upgrades sdk for remaining workspaces * tweaks history tests for current account state * adds action to hide a collectible, adds hidden collectible option in menu and hidden collectible sheet * fixes collectible detail z-index when nested, tweaks notification styles * fixes refresh collectibles state bug * extends account collectibles tests for hide and unhide changes. Adds unit and e2e tests for the hide and unhide functionality * refactor hidden collectibles callabck flow to avoid extra consumer coupling * combines common helpers for isCollectiblesHidden * refactors sheet usage to separate the body state from the open and closed state * ignores MCPs in git for now * fix: add missing isHidden prop and hidden collectibles integration * chore: remove local dev files from git tracking --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: leofelix077 <leonardoaalf077@hotmail.com> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com>
* adds better handling of balance call failures to the sign transaction view. Tweaks logic for insufficient balance warning to degrade silently in case of balance failures. Adds test cases for balance failures in the sign transaction flow * uses constant for network passphrase for insufficient fee unit test * uses constant for network passphrase for remaining unit tests in sign-transaction * tweaks balances signature for null preference
… check for SAC assets in order to decide to add a token ID or change a trustline. Adds supporting unit tests. (#2567)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements functionality to hide/show collectibles in the wallet, allowing users to manage which NFTs are visible in their collection view. It also improves the transaction signing flow by handling balance fetch failures gracefully instead of blocking transactions.
Changes:
- Added hidden collectibles feature with UI for viewing and managing hidden NFTs
- Modified balance fetching in transaction signing to continue with null balances on failure
- Added new API endpoints and handlers for collectible visibility management
Reviewed changes
Copilot reviewed 34 out of 42 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| extension/src/popup/views/tests/SignTransaction.test.tsx | Added test for transaction signing without balance data |
| extension/src/popup/views/SignTransaction/index.tsx | Updated balance check to handle null balances gracefully |
| extension/src/popup/views/SignTransaction/hooks/useGetSignTxData.tsx | Changed balance fetching to soft-fail with null instead of throwing errors |
| extension/src/popup/views/SignTransaction/hooks/tests/useGetSignTxData.test.tsx | Added test for graceful balance fetch failure handling |
| extension/src/popup/views/Account/styles.scss | Added height styling for account view |
| extension/src/popup/views/Account/index.tsx | Integrated hidden collectibles hook and props |
| extension/src/popup/styles/global.scss | Updated notification border radius |
| extension/src/popup/locales/pt/translation.json | Added Portuguese translations for hidden collectibles |
| extension/src/popup/locales/en/translation.json | Added English translations for hidden collectibles |
| extension/src/popup/components/manageAssets/ManageAssetRows/ChangeTrustInternal/hooks/useChangeTrustData.tsx | Added blank line for formatting |
| extension/src/popup/components/manageAssets/ManageAssetRows/ChangeTrustInternal/SubmitTx/index.tsx | Added SAC detection logic to determine trustline submission flow |
| extension/src/popup/components/manageAssets/AddAsset/index.tsx | Added blank line for formatting |
| extension/src/popup/components/account/hooks/useHiddenCollectibles.ts | Created hook for managing hidden collectibles state |
| extension/src/popup/components/account/HiddenCollectibles/styles.scss | Added styles for hidden collectibles sheet |
| extension/src/popup/components/account/HiddenCollectibles/index.tsx | Implemented hidden collectibles view component |
| extension/src/popup/components/account/CollectibleInfo/styles.scss | Removed fixed dimensions from collectible image |
| extension/src/popup/components/account/CollectibleInfo/index.tsx | Made collectible image rendering conditional |
| extension/src/popup/components/account/CollectibleDetail/styles.scss | Updated icon styling and added z-index for popover |
| extension/src/popup/components/account/CollectibleDetail/index.tsx | Added isHidden prop and notification display |
| extension/src/popup/components/account/AccountTabs/index.tsx | Integrated hidden collectibles functionality |
| extension/src/popup/components/account/AccountHeader/index.tsx | Passed hidden collectibles props through to tabs |
| extension/src/popup/components/account/AccountCollectibles/styles.scss | Added styles for hidden collectible display |
| extension/src/popup/components/tests/ManageAssetRows.test.tsx | Added test for SAC asset trustline handling |
| extension/src/popup/components/tests/HiddenCollectibles.test.tsx | Added comprehensive tests for hidden collectibles feature |
| extension/src/popup/components/tests/CollectibleDetail.test.tsx | Added tests for hidden collectible notification display |
| extension/src/constants/localStorageTypes.ts | Added constant for hidden collectibles storage |
| extension/src/background/messageListener/popupMessageListener.ts | Added message handlers for collectible visibility |
| extension/src/background/messageListener/handlers/getHiddenCollectibles.ts | Implemented handler to retrieve hidden collectibles |
| extension/src/background/messageListener/handlers/changeCollectibleVisibility.ts | Implemented handler to update collectible visibility |
| extension/e2e-tests/hideCollectible.test.ts | Added end-to-end tests for hiding/showing collectibles |
| @shared/constants/services.ts | Added service types for collectible visibility operations |
| @shared/api/types/types.ts | Added types for collectible visibility management |
| @shared/api/types/message-request.ts | Added message types for collectible visibility requests |
| @shared/api/internal.ts | Added API functions for collectible visibility operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+18
| &__icon { | ||
| width: pxToRem(20px); | ||
| height: pxToRem(20px); | ||
| stroke: var(--sds-clr-gray-11); | ||
| color: var(--sds-clr-gray-11); | ||
| } |
There was a problem hiding this comment.
The class name &__icon is nested under CollectibleDetail__header__right-button, which creates an overly long selector path. Consider using a more direct class name or flattening the structure.
Comment on lines
+243
to
+244
| "Hidden collectibles": "Hidden collectibles", | ||
| "Hidden Collectibles": "Hidden Collectibles", |
There was a problem hiding this comment.
Portuguese translations are missing - the English text is used instead. These strings should be translated to Portuguese.
| "No connected apps found": "Nenhum app conectado encontrado", | ||
| "No description available": "Nenhuma descrição disponível", | ||
| "No device detected.": "Nenhum dispositivo detectado.", | ||
| "No hidden collectibles": "No hidden collectibles", |
There was a problem hiding this comment.
Portuguese translation is missing - the English text is used instead. This string should be translated to Portuguese.
Suggested change
| "No hidden collectibles": "No hidden collectibles", | |
| "No hidden collectibles": "Nenhum colecionável oculto", |
| "This asset was flagged as spam": "Este ativo foi marcado como spam", | ||
| "This asset was flagged as suspicious": "Este ativo foi marcado como suspeito", | ||
| "This can be used to sign arbitrary transaction hashes without having to decode them first.": "Isso pode ser usado para assinar hashes de transação arbitrários sem precisar decodificá-los primeiro.", | ||
| "This collectible is hidden": "This collectible is hidden", |
There was a problem hiding this comment.
Portuguese translation is missing - the English text is used instead. This string should be translated to Portuguese.
Suggested change
| "This collectible is hidden": "This collectible is hidden", | |
| "This collectible is hidden": "Este colecionável está oculto", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.