Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Stellar Disbursement Platform (SDP) from version 6.0.1 to 6.1.0. The primary purpose is to add support for RPC configuration, embedded wallets, and SEP-45 web authentication features.
Changes:
- Updated version numbers from 6.0.1 to 6.1.0 across Chart.yaml, Docker image tags, and README
- Added new global RPC configuration options (
url,requestAuthHeaderKey,requestAuthHeaderValue) to support embedded wallets and SEP-45 features - Introduced SEP-45 contract IDs that are automatically configured based on network type (pubnet/testnet)
- Enhanced ConfigMap and Secret templates for SDP, TSS, and Dashboard to support RPC configuration
- Updated documentation URL in NOTES.txt to include
/docs/path prefix
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/stellar-disbursement-platform/Chart.yaml | Version bump from 6.0.1 to 6.1.0 |
| charts/stellar-disbursement-platform/values.yaml | Added RPC configuration parameters, embedded wallets and SEP-45 settings, updated image tags |
| charts/stellar-disbursement-platform/templates/_helpers.tpl | Added sdp.rpcEnabled helper function, removed trailing newline |
| charts/stellar-disbursement-platform/templates/01.1-configmap-sdp.yaml | Added SEP45_CONTRACT_ID defaults and RPC configuration injection from global values |
| charts/stellar-disbursement-platform/templates/01.3-configmap-tss.yaml | Added RPC configuration injection from global values |
| charts/stellar-disbursement-platform/templates/01.4-configmap-dashboard.yaml | Added RPC_ENABLED flag based on global RPC configuration |
| charts/stellar-disbursement-platform/templates/05.1-secrets-sdp.yaml | Added RPC_REQUEST_AUTH_HEADER_VALUE secret injection |
| charts/stellar-disbursement-platform/templates/05.3-secrets-tss.yaml | Added RPC_REQUEST_AUTH_HEADER_VALUE secret injection |
| charts/stellar-disbursement-platform/templates/NOTES.txt | Updated documentation URL to include /docs/ path |
| charts/stellar-disbursement-platform/minimal-values.yaml | Added example RPC URL configuration |
| charts/stellar-disbursement-platform/README.md | Updated parameter documentation table with new RPC settings and version references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| url: "" | ||
| ## @param global.rpc.requestAuthHeaderKey The name of the HTTP header to include when authenticating requests to a protected RPC server. | ||
| requestAuthHeaderKey: "" | ||
| ## @param global.rpc.requestAuthHeaderValue he value of the HTTP header used for authenticating requests to a protected RPC server. |
There was a problem hiding this comment.
There is a spelling error in the description. "he value" should be "The value" (capital T).
Suggested change
| ## @param global.rpc.requestAuthHeaderValue he value of the HTTP header used for authenticating requests to a protected RPC server. | |
| ## @param global.rpc.requestAuthHeaderValue The value of the HTTP header used for authenticating requests to a protected RPC server. |
philipliu
approved these changes
Feb 4, 2026
marwen-abid
force-pushed
the
sdp/release-6.1.0
branch
from
fc268b0 to
a27ea23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing changes for SDP 6.1.0