Merged
Conversation
ifropc
force-pushed
the
basic-test
branch
6 times, most recently
from
fa9bd0a to
7c703c7
Compare
leighmcculloch
approved these changes
Mar 26, 2025
Comment on lines
+4
to
+5
| push: | ||
| branches: [main, release/**] |
Member
There was a problem hiding this comment.
We should be running this on pull request as well.
Contributor
Author
There was a problem hiding this comment.
Hmm yeah actually I think it should also run after build jobs and using correct ref from the hub
Member
There was a problem hiding this comment.
It could do that, but it's actually good in some ways to use the current latest, because that's the way we should make changes to the action. Changes to the action should probably never occur in lockstep with the image, otherwise people will see breakages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.