Skip to content

Update dependencies#340

Merged
jeesunikim merged 2 commits intomainfrom
update-deps
Jan 30, 2026
Merged

Update dependencies#340
jeesunikim merged 2 commits intomainfrom
update-deps

Conversation

@jeesunikim
Copy link
Contributor

@jeesunikim jeesunikim commented Jan 29, 2026

  1. The majority of the transitive dependencies come from docusarus. We have the latest docusarus so I resolved the issues by using resolutions
  2. While I was checking the final docusarus page, there was a run time error when entering badge page. I updated src/components/Floater/index.tsx to resolve the error.

The error was

TypeError: Cannot read properties of null (reading 'style')
at computeFloaterPosition

@jeesunikim jeesunikim requested review from Copilot and quietbits and removed request for Copilot January 29, 2026 23:00
@socket-security

This comment was marked as resolved.

@stellar-jenkins
Copy link

Copilot AI review requested due to automatic review settings January 29, 2026 23:27
@stellar-jenkins
Copy link

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependencies and fixes a runtime error in the Floater component. The dependency updates primarily address transitive dependencies from Docusaurus using yarn resolutions, and the Floater fix prevents a null reference error when accessing style properties.

Changes:

  • Added yarn resolutions to consolidate versions of glob, path-to-regexp, and cross-spawn
  • Fixed null reference error in Floater component by adding null safety check before accessing floaterRef.current.style
  • Updated node-forge from 1.3.1 to 1.3.2

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Added resolutions for glob, path-to-regexp, and cross-spawn to consolidate transitive dependencies
yarn.lock Consolidated dependency versions based on package.json resolutions; updated node-forge to 1.3.2
@stellar/design-system/src/components/Floater/index.tsx Added null safety check for floaterRef.current.style to prevent runtime error; applied code formatting improvements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"glob": "11.1.0",
"path-to-regexp": "1.9.0",
"cross-spawn": "7.0.6"
},
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resolution consolidates path-to-regexp from multiple major versions (0.1.x, 1.x, 3.x) to 1.9.0. This is a valid approach for managing transitive dependencies from Docusaurus. However, consider documenting this resolution choice (e.g., in a comment or README) to help future maintainers understand why these versions are being forced together, especially since path-to-regexp can have breaking changes between major versions.

Suggested change
},
},
"pathToRegexpResolutionNote": "We pin 'path-to-regexp' to 1.9.0 via 'resolutions' to consolidate multiple transitive major versions (0.1.x, 1.x, 3.x) used by Docusaurus. Changing or removing this override may reintroduce version conflicts or behavior changes because 'path-to-regexp' has breaking changes between major versions.",

Copilot uses AI. Check for mistakes.
@jeesunikim jeesunikim merged commit 62a0500 into main Jan 30, 2026
12 checks passed
@jeesunikim jeesunikim deleted the update-deps branch January 30, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants