Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Preview is available here: |
|
Preview is available here: |
There was a problem hiding this comment.
Pull request overview
This PR updates dependencies and fixes a runtime error in the Floater component. The dependency updates primarily address transitive dependencies from Docusaurus using yarn resolutions, and the Floater fix prevents a null reference error when accessing style properties.
Changes:
- Added yarn resolutions to consolidate versions of glob, path-to-regexp, and cross-spawn
- Fixed null reference error in Floater component by adding null safety check before accessing floaterRef.current.style
- Updated node-forge from 1.3.1 to 1.3.2
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Added resolutions for glob, path-to-regexp, and cross-spawn to consolidate transitive dependencies |
| yarn.lock | Consolidated dependency versions based on package.json resolutions; updated node-forge to 1.3.2 |
| @stellar/design-system/src/components/Floater/index.tsx | Added null safety check for floaterRef.current.style to prevent runtime error; applied code formatting improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "glob": "11.1.0", | ||
| "path-to-regexp": "1.9.0", | ||
| "cross-spawn": "7.0.6" | ||
| }, |
There was a problem hiding this comment.
The resolution consolidates path-to-regexp from multiple major versions (0.1.x, 1.x, 3.x) to 1.9.0. This is a valid approach for managing transitive dependencies from Docusaurus. However, consider documenting this resolution choice (e.g., in a comment or README) to help future maintainers understand why these versions are being forced together, especially since path-to-regexp can have breaking changes between major versions.
| }, | |
| }, | |
| "pathToRegexpResolutionNote": "We pin 'path-to-regexp' to 1.9.0 via 'resolutions' to consolidate multiple transitive major versions (0.1.x, 1.x, 3.x) used by Docusaurus. Changing or removing this override may reintroduce version conflicts or behavior changes because 'path-to-regexp' has breaking changes between major versions.", |
resolutionsbadgepage. I updated src/components/Floater/index.tsx to resolve the error.The error was