Skip to content

Conversation

@Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jun 18, 2025

We should use the RPC SDK when possible instead of building requests by hand

This does somewhat depend on #141 for general sanity.

@Shaptic Shaptic requested review from a team and sreuland June 18, 2025 19:39
@Shaptic Shaptic changed the title Migrate to use built-in RPC client, fix getEvents expectations Migrate to use built-in RPC client Aug 7, 2025
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. If you wanted to test the test, locally:

make \
    CORE_GIT_REF=https://github.com/stellar/stellar-core.git#v23.0.0rc4 \
    STELLAR_RPC_GIT_REF=https://github.com/stellar/stellar-rpc.git#vv23.0.0-rc.2 \
    SOROBAN_CLI_GIT_REF=https://github.com/stellar/stellar-cli.git#v23.0.0 \
    RS_XDR_GIT_REF=v23.0.0-rc.2 \
    GO_GIT_REF=https://github.com/stellar/go.git#v23.0.0-rc2
    JS_STELLAR_SDK_NPM_VERSION=v14.0.0-rc.3 \
    build

docker run --rm -t --name e2e_test \
stellar/system-test:dev \
--VerboseOutput true \
--SorobanExamplesGitHash v22.0.1

I get most of the versions from the qs build-testing target

@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 7, 2025

@sreuland building core takes forever heh but I'm running it right now, will merge once it passes

@sreuland
Copy link
Contributor

sreuland commented Aug 8, 2025

@sreuland building core takes forever heh but I'm running it right now, will merge once it passes

doh, yes, you can bypass the core build-from-source time by referring to a pre-built core image with SYSTEM_TEST_CORE_IMAGE and SYSTEM_TEST_CORE_IMAGE_BIN_PATH, rpc uses this shortcut on it's e2e.yml for reference.

@sreuland
Copy link
Contributor

sreuland commented Aug 8, 2025

@fnando , just a heads up on these changes which will be landing on master, they should be transparent to running tests, the stellar-clil e2e ci step builds and runs system-test go module directly using system-test/test.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants