statechanges table: Change TokenID to BYTEA#509
Open
aditya1702 wants to merge 12 commits intoopxdr-bytea-2from
Open
statechanges table: Change TokenID to BYTEA#509aditya1702 wants to merge 12 commits intoopxdr-bytea-2from
statechanges table: Change TokenID to BYTEA#509aditya1702 wants to merge 12 commits intoopxdr-bytea-2from
Conversation
Brings token_id storage in line with all other address columns that already use BYTEA. Not in production so the migration is modified directly.
Matches the BYTEA column type in the migration and is consistent with all other address fields in the struct.
WithToken now uses utils.NullAddressBytea and generateSortKey uses the String() method instead of the .String field.
Matches the NullAddressBytea type change for TokenID.
BatchInsert: use []byte slice and bytea[] SQL cast instead of text[]. BatchCopy: convert TokenID via pgtypeBytesFromNullAddressBytea instead of pgtypeTextFromNullString.
Use resolveNullableAddress for nullable TokenID fields and inline String() for the required StandardBalanceChange.tokenId field.
Use a valid Stellar contract address instead of a plain string.
Replace sql.NullString with NullAddressBytea using valid Stellar addresses in generateTestStateChanges, BatchInsert, and BatchCopy tests.
Use .String() method instead of .String field access.
Use utils.NullAddressBytea instead of utils.SQLNullString for TokenID assertion.
Use .String() method instead of .String field access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change the
TokenIDcolumn toBYTEAWhy
Storage optimization
Known limitations
N/A
Issue that this PR addresses
Closes #496