Skip to content

Fix long message importance weighting #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephen-cox merged 1 commit into from
Aug 9, 2025
Merged

Fix long message importance weighting #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nova/core/memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,10 @@ def analyze_message_importance(

# Boost importance for longer messages (more detailed)
word_count = len(message.content.split())
if word_count > 50:
importance_score += 0.2
elif word_count > 100:
if word_count > 100:
importance_score += 0.4
elif word_count > 50:
importance_score += 0.2

# Boost importance for messages with code or technical content
if any(
Expand Down
20 changes: 20 additions & 0 deletions tests/unit/test_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,26 @@ def test_analyze_message_importance_recent(self):
)
assert score > 1.0 # Base score + recency boost

def test_analyze_message_importance_long_message(self):
"""Longer messages should yield higher importance scores"""
medium_msg = Message(
role=MessageRole.USER,
content=" ".join(["word"] * 60), # 60 words
)
long_msg = Message(
role=MessageRole.USER,
content=" ".join(["word"] * 120), # 120 words
)

medium_score = self.memory_manager.analyze_message_importance(
medium_msg, self.conversation
)
long_score = self.memory_manager.analyze_message_importance(
long_msg, self.conversation
)

assert long_score > medium_score

def test_optimize_conversation_context(self):
"""Test context optimization"""
result = self.memory_manager.optimize_conversation_context(self.conversation)
Expand Down