Fix css classes on smartplacement, fix correct position after an image was loaded#131
Open
prdatur wants to merge 3 commits intostevenbenner:masterfrom
Open
Fix css classes on smartplacement, fix correct position after an image was loaded#131prdatur wants to merge 3 commits intostevenbenner:masterfrom
prdatur wants to merge 3 commits intostevenbenner:masterfrom
Conversation
added 3 commits
February 18, 2015 13:37
…l tried fallback position
…ip changes due to finished image loadings, attach on load event for every image and call to update the position on finish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix 2 issues.
First one occures when smartplacement is enabled and it needs to find another place. It will add the original placement class + the new final class.
Second issue was, that if an image load takes a bit longer. The position is not correct after the image was loaded and the height of the image was not defined before.