Skip to content

Conversation

@JosephShenton
Copy link

No description provided.

@JosephShenton JosephShenton changed the title Add New Battery Complication Add New Battery Complication & Roman Numerals Oct 14, 2018
@JosephShenton JosephShenton changed the title Add New Battery Complication & Roman Numerals Add New Battery Complication & Roman Numerals & iPhone companion app. Oct 15, 2018
@Shugabuga
Copy link

I took a look at your fork and I noticed a few things that may be worth noting:

  • You changed the team. I would try not to do that if possible.
  • That's a nice companion app. However, I cannot get it working reliably on the Simulator. The check boxes seem to reset on every launch, and changing the options while both the watch app and the companion app has a chance of just crashing the watch app (but also it does work if you are lucky, so it's probably just a bug). Given that the options are labeled WIP, you may even know about this already. I'd probably test the companion app harder so it's stable on merge.
    • It seems as only the color settings are saved too.
  • Why couldn't the battery compilation, roman numbering, and companion app be separate pull requests? The former two seem to be working just fine, but the companion app isn't as stable.
  • You renamed the entire project to "Watchie" (well, not the entire thing, but a lot of labels and the companion app use this new name). You probably should have mentioned that somewhere in the PR, or at least not have done so. That's probably another discussion.

I'm sorry in advance if it sounds like I'm nitpicking when I haven't even done anything for the project, or speaking on behalf of the repo maintainer. I do like a lot of what this PR adds, and probably would use it on my devices. I just want it to be even better by means of stability and not adding arbitrary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants