Merged
Conversation
mjbp
approved these changes
Oct 2, 2025
Collaborator
mjbp
left a comment
mjbp
left a comment
There was a problem hiding this comment.
Looks good. Thanks for cleaning up the post-validation technical debt.
catvine-stormid
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves UI based tests to playwright.
A lot of Jest tests still remain in comparison to other components - this package had very thorough unit tests of state, individual validation methods, plugins and apis that are best suited to be left there.
Also includes a refactor of post-validation functionality, as it wasn't testing as expected in safari because of its unique focus behaviour.
Closes #315 CLoses #329