This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Open
Conversation
Contributor
|
@Tweety-FER Thanks! Unfortunately after more investigation it looks as if the IdSiteModel is "correctly named". I.e. the resource is actually named idSiteModel. Which in my opinion is a little bit confusing, but it seems that the resource name is like that. @robertjd Do you have any input here? |
Member
|
Ah! I see where the confusion is here. There are two resources in the REST API:
Thus, this PR has some correct changes, but some incorrect changes. The following should be true:
Ping @Tweety-FER for changes, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the file and class. Foundnd all references in documents and tests and updated them.
Fixes #537