feat: add MCP elicitation support#329
Open
konippi wants to merge 2 commits intostrands-agents:mainfrom
Open
Conversation
konippi
had a problem deploying
to
manual-approval
GitHub Actions
Failure
pgrayy
reviewed
Jan 26, 2026
src/types/elicitation.ts
Outdated
| /** | ||
| * Parameters passed to the elicitation callback when the server requests user input. | ||
| */ | ||
| export interface ElicitRequestParams { |
Member
There was a problem hiding this comment.
Do we need to define these interfaces ourselves or does MCP have definitions already in their sdk package?
Contributor
Author
There was a problem hiding this comment.
No, we don't need it. I've made it so we use the MCP SDK types directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements elicitation support for MCP clients, enabling servers to request additional user input during tool execution.
Related Issues
#232
Documentation PR
Type of Change
New feature
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.