Skip to content

Add always condition to finalize step, fix audit, and update bash test to use real path#465

Merged
Unshure merged 3 commits intostrands-agents:mainfrom
Unshure:main
Feb 3, 2026
Merged

Add always condition to finalize step, fix audit, and update bash test to use real path#465
Unshure merged 3 commits intostrands-agents:mainfrom
Unshure:main

Conversation

@Unshure
Copy link
Member

@Unshure Unshure commented Jan 30, 2026

Description

Add always() so that label cleanup always happens

example where we need this: https://github.com/strands-agents/sdk-python/actions/runs/21530320818/job/62044415203

  • Additionally fix an audit issue
  • Update bash test to use real path

Related Issues

N/A

Documentation PR

N/A

Type of Change

Bug fix

Testing

How have you tested the change?

  • I ran npm run check

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pgrayy
pgrayy previously approved these changes Feb 2, 2026
@Unshure Unshure changed the title Add always condition to finalize step Add always condition to finalize step, fix audit, and update bash test to use real path Feb 2, 2026
@Unshure Unshure enabled auto-merge February 2, 2026 20:42
@mehtarac
Copy link
Member

mehtarac commented Feb 3, 2026

Integ test timed out: test/integ/agent.test.ts > Agent with 'BedrockModel' > BedrockModel Integration Tests > handles tool invocation Error: Test timed out in 60000ms.. Non-blocker

@Unshure Unshure added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
@Unshure Unshure added this pull request to the merge queue Feb 3, 2026
Merged via the queue into strands-agents:main with commit 3a991c6 Feb 3, 2026
22 of 43 checks passed
dbschmigelski pushed a commit to dbschmigelski/sdk-typescript that referenced this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants