Skip to content

Decrease tx hash calculations #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quantumagi merged 1 commit into from
Jul 4, 2022
Merged

Decrease tx hash calculations #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Stratis.Bitcoin.Features.Consensus/CoinViews/CoinviewHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ public OutPoint[] GetIdsToFetch(Block block, bool enforceBIP30)
{
if (enforceBIP30)
{
// Calculate the hash outside the loop.
var txId = tx.GetHash();
foreach (var utxo in tx.Outputs.AsIndexedOutputs())
ids.Add(utxo.ToOutPoint());
ids.Add(new OutPoint() { Hash = txId, N = utxo.N });
}

if (!tx.IsCoinBase)
Expand Down
7 changes: 5 additions & 2 deletions src/Stratis.Bitcoin.Features.Consensus/UnspentOutputSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ public void Update(Network network, Transaction transaction, int height)
}
}

foreach (IndexedTxOut output in transaction.Outputs.AsIndexedOutputs())
// Hash calculations are slow. Do this one outside the loop...
var txHash = transaction.GetHash();

foreach (IndexedTxOut output in transaction.Outputs.AsIndexedOutputs().ToList())
{
var outpoint = output.ToOutPoint();
var outpoint = new OutPoint() { Hash = txHash, N = output.N };
var coinbase = transaction.IsCoinBase;
var coinstake = network.Consensus.IsProofOfStake ? transaction.IsCoinStake : false;

Expand Down