Enable coin view to "catch up" if forked or below chain tip#1016
Merged
quantumagi merged 4 commits intostratisproject:release/1.4.0.0from Jul 12, 2022
Merged
Enable coin view to "catch up" if forked or below chain tip#1016quantumagi merged 4 commits intostratisproject:release/1.4.0.0from
quantumagi merged 4 commits intostratisproject:release/1.4.0.0from
Conversation
quantumagi
changed the title
quantumagi
changed the title
quantumagi
changed the title
zeptin
reviewed
Jul 8, 2022
src/Stratis.Bitcoin.Features.Consensus/CoinViews/CachedCoinView.cs
Outdated
Show resolved
Hide resolved
zeptin
approved these changes
Jul 11, 2022
quantumagi
added a commit
to quantumagi/StratisFullNode-1
that referenced
this pull request
Jan 30, 2023
…roject#1016) * Coin view to catch-up if off-chain or below chain tip * Changes based on feedback * Fix missing argument (cherry picked from commit 6fc76e1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been split off PR #995 to make that PR easier to review.
Previously the blockstore and chain would be rewound in this scenario resulting in blocks being re-requested from peers. After this PR we will instead rebuild the coin view with blocks already present in the block store (subject to the consensus chain).