Skip to content

Fix uninitilized class members in LocalCallContract #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quantumagi wants to merge 2 commits into
base: release/1.6.0.0
Choose a base branch
from
Open

Fix uninitilized class members in LocalCallContract #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59840fe
Fix uninitilized class members in LocalCallContract
quantumagi Mar 30, 2023
4c1c97f
Pass required arguments
quantumagi Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Stratis.Features.Unity3dApi/LocalCallContract.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,15 @@ public class LocalCallContract : ILocalCallContract
private readonly IContractPrimitiveSerializer primitiveSerializer;
private readonly IContractAssemblyCache contractAssemblyCache;

public LocalCallContract(Network network, ISmartContractTransactionService smartContractTransactionService, ChainIndexer chainIndexer, ILocalExecutor localExecutor)
public LocalCallContract(Network network, ISmartContractTransactionService smartContractTransactionService, ChainIndexer chainIndexer, ILocalExecutor localExecutor,
IContractPrimitiveSerializer contractPrimitiveSerializer, IContractAssemblyCache contractAssemblyCache)
{
this.network = network;
this.chainIndexer = chainIndexer;
this.smartContractTransactionService = smartContractTransactionService;
this.localExecutor = localExecutor;
this.primitiveSerializer = contractPrimitiveSerializer;
this.contractAssemblyCache = contractAssemblyCache;
}

public LocalExecutionResponse LocalCallSmartContract(LocalCallContractRequest request)
Expand Down
8 changes: 6 additions & 2 deletions src/Stratis.Features.Unity3dApi/NFTTransferIndexer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
using Stratis.Bitcoin.Features.SmartContracts.Wallet;
using Stratis.Bitcoin.Utilities;
using Stratis.SmartContracts.CLR;
using Stratis.SmartContracts.CLR.Caching;
using Stratis.SmartContracts.CLR.Serialization;
using FileMode = LiteDB.FileMode;

namespace Stratis.Features.Unity3dApi
Expand Down Expand Up @@ -65,7 +67,9 @@ public class NFTTransferIndexer : INFTTransferIndexer
private IAsyncLoop indexingLoop;

public NFTTransferIndexer(DataFolder dataFolder, ILoggerFactory loggerFactory, IAsyncProvider asyncProvider, INodeLifetime nodeLifetime,
ChainIndexer chainIndexer, Network network, ILocalExecutor localExecutor, Unity3dApiSettings apiSettings, ISmartContractTransactionService smartContractTransactionService = null)
ChainIndexer chainIndexer, Network network, ILocalExecutor localExecutor, Unity3dApiSettings apiSettings,
ISmartContractTransactionService smartContractTransactionService = null, IContractPrimitiveSerializer contractPrimitiveSerializer = null,
IContractAssemblyCache contractAssemblyCache = null)
{
this.network = network;
this.dataFolder = dataFolder;
Expand All @@ -74,7 +78,7 @@ public NFTTransferIndexer(DataFolder dataFolder, ILoggerFactory loggerFactory, I
this.nodeLifetime = nodeLifetime;
this.chainIndexer = chainIndexer;

var localCallContract = new LocalCallContract(network, smartContractTransactionService, chainIndexer, localExecutor);
var localCallContract = new LocalCallContract(network, smartContractTransactionService, chainIndexer, localExecutor, contractPrimitiveSerializer, contractAssemblyCache);

this.nftContractLocalClient = new NftContractLocalClient(localCallContract, apiSettings.LocalCallSenderAddress);
this.smartContractTransactionService = smartContractTransactionService;
Expand Down