feat(charts): add Helm chart for StreamNative MCP Server by freeznet · Pull Request #67 · streamnative/streamnative-mcp-server

freeznet · 2026-01-08T04:06:07Z

No description provided.

Copilot

Pull request overview

This PR adds a comprehensive Helm chart for deploying the StreamNative MCP Server on Kubernetes in Multi-Session Pulsar mode, along with refactoring the SSE server code to support health endpoints and updating the golangci-lint configuration.

Key changes:

Refactored SSE server to support health and readiness endpoints (/healthz and /readyz)
Unified HTTP server lifecycle management for both single and multi-session modes
Added complete Helm chart with configurable deployment, service, ingress, and security settings
Updated golangci-lint to v2.7.2 with new configuration format

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/schema/common.go	Updated comment translation from Chinese to English
pkg/cmd/mcp/sse.go	Major refactoring: added health endpoints, unified HTTP server management, simplified authentication middleware
charts/snmcp/Chart.yaml	Helm chart metadata for StreamNative MCP Server v0.1.0
charts/snmcp/values.yaml	Comprehensive values configuration with Pulsar, TLS, session, and Kubernetes resource settings
charts/snmcp/templates/deployment.yaml	Kubernetes deployment with multi-session Pulsar mode, health probes, and security contexts
charts/snmcp/templates/configmap.yaml	ConfigMap for environment variable configuration
charts/snmcp/templates/service.yaml	Kubernetes service definition
charts/snmcp/templates/ingress.yaml	Optional ingress configuration
charts/snmcp/templates/serviceaccount.yaml	Service account template
charts/snmcp/templates/_helpers.tpl	Helm template helper functions
charts/snmcp/templates/NOTES.txt	Post-installation instructions
charts/snmcp/README.md	Comprehensive chart documentation with examples
CLAUDE.md	Updated architecture documentation with builder registry pattern and feature flags
AGENTS.md	Added reference to CLAUDE.md
.golangci.yml	Migrated to golangci-lint v2 configuration format
.github/workflows/lint.yaml	Updated golangci-lint version to 2.7.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.golangci.yml

charts/snmcp/templates/configmap.yaml

pkg/cmd/mcp/sse.go

charts/snmcp/templates/deployment.yaml

…etails

This reverts commit ebef862.

…r into freeznet/helm-charts # Conflicts: # pkg/cmd/mcp/sse.go

Copilot

Pull request overview

Copilot reviewed 19 out of 23 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

charts/snmcp/templates/deployment.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 19 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T04:40:46Z

charts/snmcp/templates/deployment.yaml

+              path: {{ trimSuffix "/" .Values.server.httpPath }}/readyz
+              port: http
+            initialDelaySeconds: 5
+            periodSeconds: 10


The readiness probe has a timeout of 3 seconds and failure threshold of 3, meaning the pod will be marked not ready after 3 consecutive failures. However, the periodSeconds is 10, so it would take 30 seconds to detect if the service becomes unhealthy. For SSE connections and MCP server operations, consider if this delay is acceptable or if a shorter period (e.g., 5s) would provide faster detection of service issues.

Suggested change

periodSeconds: 10

periodSeconds: 5

Copilot · 2026-01-13T04:40:47Z

charts/snmcp/templates/configmap.yaml

+  SNMCP_CONFIG_DIR: {{ .Values.server.configDir | quote }}
+  SNMCP_READ_ONLY: {{ .Values.server.readOnly | quote }}
+  {{- if .Values.server.features }}
+  SNMCP_FEATURES: {{ .Values.server.features | join "," | quote }}
+  {{- end }}
+  {{- if .Values.pulsar.tls.enabled }}


The ConfigMap defines SNMCP_CONFIG_DIR and SNMCP_READ_ONLY environment variables, but these don't appear to be used by the application. The deployment.yaml passes --read-only as a command-line flag (line 56) when readOnly is true, and server.configDir is not passed as a command-line argument at all. These unused environment variables could be removed from the ConfigMap, or if they're intended to be used, the deployment should reference them.

Suggested change

SNMCP_CONFIG_DIR: {{ .Values.server.configDir | quote }}

SNMCP_READ_ONLY: {{ .Values.server.readOnly | quote }}

{{- if .Values.server.features }}

SNMCP_FEATURES: {{ .Values.server.features | join "," | quote }}

{{- end }}

{{- if .Values.pulsar.tls.enabled }}

{{- if .Values.server.features }}

SNMCP_FEATURES: {{ .Values.server.features | join "," | quote }}

{{- end }}

{{- if .Values.pulsar.tls.enabled }}

{{- if .Values.pulsar.tls.enabled }}

Copilot · 2026-01-13T04:40:47Z

charts/snmcp/templates/deployment.yaml

+          livenessProbe:
+            httpGet:
+              path: {{ trimSuffix "/" .Values.server.httpPath }}/healthz
+              port: http
+            initialDelaySeconds: 10
+            periodSeconds: 30
+            timeoutSeconds: 5
+            failureThreshold: 3


Consider adding a startupProbe in addition to the liveness and readiness probes. This would prevent the liveness probe from killing the container during slow startup scenarios (e.g., when connecting to an external Pulsar cluster with network delays). A startup probe with a longer failureThreshold would give the application more time to initialize while still allowing fast health checks once running.

Copilot · 2026-01-13T04:40:47Z

charts/snmcp/e2e/test-secret.key

@@ -0,0 +1 @@
+snmcp-e2e-test-secret-key-32-bytes-long


The secret key "snmcp-e2e-test-secret-key-32-bytes-long" is exactly 39 bytes (characters), not 32 bytes as the name suggests. This is potentially misleading. Consider using a key that's actually 32 bytes or updating the name to match the actual length, or documenting why the length differs from the name.

Suggested change

snmcp-e2e-test-secret-key-32-bytes-long

snmcp-e2e-test-secret-key-39-bytes-long

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

freeznet added 2 commits January 8, 2026 11:18

feat(charts): add Helm chart for StreamNative MCP Server

acc8556

refactor(server): improve SSE server structure and add health endpoints

38fab48

freeznet self-assigned this Jan 8, 2026

freeznet requested a review from a team as a code owner January 8, 2026 04:06

freeznet requested a review from Copilot January 8, 2026 04:06

Copilot started reviewing on behalf of freeznet January 8, 2026 04:06 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

.golangci.yml Show resolved Hide resolved

charts/snmcp/templates/configmap.yaml Outdated Show resolved Hide resolved

pkg/cmd/mcp/sse.go Outdated Show resolved Hide resolved

charts/snmcp/templates/deployment.yaml Show resolved Hide resolved

freeznet added 8 commits January 8, 2026 13:27

feat(e2e): add e2e testing setup with Pulsar and Helm

9c96021

ci(e2e): add E2E workflow and update related configurations

a2ec45b

docs(claude): update CLAUDE.md with build commands and architecture d…

3cd837f

…etails

refactor(auth): migrate from dgrijalva/jwt-go to golang-jwt/jwt

ebef862

Revert "refactor(auth): migrate from dgrijalva/jwt-go to golang-jwt/jwt"

72e180c

This reverts commit ebef862.

Merge branch 'main' of github.com:streamnative/streamnative-mcp-serve…

0cc39b6

…r into freeznet/helm-charts # Conflicts: # pkg/cmd/mcp/sse.go

ci(e2e): add cluster name to Kind setup and package doc

6e39f9f

ci(e2e): simplify E2E workflow by consolidating steps

0c42661

freeznet requested a review from Copilot January 12, 2026 13:52

Copilot started reviewing on behalf of freeznet January 12, 2026 13:52 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

charts/snmcp/templates/deployment.yaml Show resolved Hide resolved

freeznet and others added 4 commits January 12, 2026 22:56

Update charts/snmcp/templates/configmap.yaml

6a0d9c1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update pkg/cmd/mcp/sse.go

7dc89cc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

docs(helm): clarify configDir must be writable

03a7a43

refactor(helm): remove hardcoded httpAddr and clarify port usage

af7151d

freeznet requested a review from Copilot January 13, 2026 04:34

Copilot started reviewing on behalf of freeznet January 13, 2026 04:35 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

jiangpengcheng approved these changes Jan 14, 2026

View reviewed changes

freeznet merged commit 4dc4577 into main Jan 14, 2026
17 checks passed

freeznet added a commit that referenced this pull request Jan 19, 2026

feat(charts): add Helm chart for StreamNative MCP Server (#67)

224769a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(charts): add Helm chart for StreamNative MCP Server#67

feat(charts): add Helm chart for StreamNative MCP Server#67
freeznet merged 14 commits intomainfrom
freeznet/helm-charts

freeznet commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	snmcp-e2e-test-secret-key-32-bytes-long
	snmcp-e2e-test-secret-key-39-bytes-long

Conversation

freeznet commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants