Skip to content

Conversation

@freeznet
Copy link
Member

@freeznet freeznet commented Feb 4, 2026

No description provided.

@freeznet freeznet self-assigned this Feb 4, 2026
@freeznet freeznet requested a review from a team as a code owner February 4, 2026 02:22
@freeznet freeznet requested a review from Copilot February 4, 2026 02:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Fully Qualified Function Name (FQFN) support and numerous optional parameters to the Pulsar Functions tool, significantly enhancing its flexibility and usability.

Changes:

  • Introduces FQFN format (tenant/namespace/name) as an alternative to specifying tenant, namespace, and name separately
  • Makes tenant and namespace optional with sensible defaults (public and default)
  • Adds 50+ optional parameters for comprehensive function configuration including resource limits, windowing, secrets, serialization, and more
  • Adds support for per-instance stats/status queries via instanceId parameter
  • Adds triggerFile as an alternative to triggerValue for trigger operations
  • Adds YAML config file support via functionConfigFile parameter

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pkg/mcp/builders/pulsar/functions.go Core implementation adding FQFN parsing, parameter handling, validation logic, and helper functions
pkg/mcp/builders/pulsar/functions_parity_test.go Unit tests for FQFN parsing, validation, and update argument checking
docs/tools/pulsar_admin_functions.md Documentation updates reflecting new optional parameters and FQFN support
cmd/snmcp-e2e/main.go E2E test additions covering function create, update, trigger, and delete operations
cmd/snmcp-e2e/testdata/functions/echo.py Simple Python echo function for E2E testing
Dockerfile Adds echo.py to Docker image for E2E test availability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants