-
Notifications
You must be signed in to change notification settings - Fork 5
feat(pulsar-functions): add FQFN support and optional parameters #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Fully Qualified Function Name (FQFN) support and numerous optional parameters to the Pulsar Functions tool, significantly enhancing its flexibility and usability.
Changes:
- Introduces FQFN format (
tenant/namespace/name) as an alternative to specifying tenant, namespace, and name separately - Makes tenant and namespace optional with sensible defaults (
publicanddefault) - Adds 50+ optional parameters for comprehensive function configuration including resource limits, windowing, secrets, serialization, and more
- Adds support for per-instance stats/status queries via
instanceIdparameter - Adds
triggerFileas an alternative totriggerValuefor trigger operations - Adds YAML config file support via
functionConfigFileparameter
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/mcp/builders/pulsar/functions.go | Core implementation adding FQFN parsing, parameter handling, validation logic, and helper functions |
| pkg/mcp/builders/pulsar/functions_parity_test.go | Unit tests for FQFN parsing, validation, and update argument checking |
| docs/tools/pulsar_admin_functions.md | Documentation updates reflecting new optional parameters and FQFN support |
| cmd/snmcp-e2e/main.go | E2E test additions covering function create, update, trigger, and delete operations |
| cmd/snmcp-e2e/testdata/functions/echo.py | Simple Python echo function for E2E testing |
| Dockerfile | Adds echo.py to Docker image for E2E test availability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.