feat: support loki bucket for aws BYOC poolmembers #170
Merged
Conversation
added 16 commits
July 25, 2025 11:41
Contributor
|
@ignacioli:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-info-missing
Contributor
|
@ignacioli:Thanks for providing doc info! |
dpappa
approved these changes
Jul 31, 2025
ignacioli
pushed a commit
that referenced
this pull request
Jul 31, 2025
🤖 I have created a release *beep* *boop* --- ## [4.4.0](v4.3.2...v4.4.0) (2025-07-31) ### Features * add iam submodule for managing applications iam ([#162](#162)) ([8ea10c0](8ea10c0)) * support loki bucket for aws BYOC poolmembers ([#170](#170)) ([92713e7](92713e7)) * **vpc:** add enable_s3_gateway_endpoint variable ([#168](#168)) ([5211726](5211726)) * **vpc:** add s3 gateway endpoint ([#165](#165)) ([9e5a88b](9e5a88b)) ### Reverts * support loki bucket for aws BYOC poolmembers ([#169](#169)) ([055f7f2](055f7f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
maxsxu
pushed a commit
that referenced
this pull request
Aug 15, 2025
<!-- ~ Copyright 2023 StreamNative, Inc. ~ ~ Licensed under the Apache License, Version 2.0 (the "License"); ~ you may not use this file except in compliance with the License. ~ You may obtain a copy of the License at ~ ~ http://www.apache.org/licenses/LICENSE-2.0 ~ ~ Unless required by applicable law or agreed to in writing, software ~ distributed under the License is distributed on an "AS IS" BASIS, ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. ~ See the License for the specific language governing permissions and ~ limitations under the License. --> <!-- - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> Master Issue: streamnative/product-roadmap#1039 BYOC AWS PoolMember bucket automation 1. Create s3 bucket for Loki in StreamNative's AWS account. 2. Remove terraform life-cycle policy, which is a tech debt, and we don’t need it. - [x] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* Check the box below. Need to update docs? - [x] `doc` See readme https://github.com/streamnative/terraform-aws-cloud/blob/master/modules/dns-bucket/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Master Issue: https://github.com/streamnative/product-roadmap/issues/1039
BYOC AWS PoolMember bucket automation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
docSee readme https://github.com/streamnative/terraform-aws-cloud/blob/master/modules/dns-bucket/README.md