Filter by funding type in Google Pay #12117
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Diffuse output: APKDEX |
toluo-stripe
force-pushed
the
tolu/funding/gpay
branch
from
daa8f44 to
4acd8c8
Compare
toluo-stripe
force-pushed
the
tolu/funding/gpay
branch
3 times, most recently
from
280c8d8 to
7ed8343
Compare
toluo-stripe
commented
Dec 11, 2025
Comment on lines
+699
to
+700
| cardFundingFilter = DefaultCardFundingFilter, | ||
| cardBrandFilter = DefaultCardBrandFilter |
Contributor
Author
There was a problem hiding this comment.
This is not used to present Google, but only to determine the ready state, hence the default filter implementations are fine here. Plus, this state is fetched async before we get the elements session. Using the merchant defined filters will require use to wait for elements session to load so we can use the feature flag, and would make latency worse.
Collaborator
There was a problem hiding this comment.
Might be worth a code comment, as this feels relevant long term.
toluo-stripe
commented
Dec 11, 2025
Comment on lines
705
to
711
| private suspend fun isGooglePaySupportedOnDevice(): Boolean { | ||
| return googlePayRepositoryFactory(GooglePayEnvironment.Production).isReady().first() | ||
| return googlePayRepositoryFactory( | ||
| environment = GooglePayEnvironment.Production, | ||
| cardBrandFilter = DefaultCardBrandFilter, | ||
| cardFundingFilter = DefaultCardFundingFilter | ||
| ).isReady().first() | ||
| } |
toluo-stripe
force-pushed
the
tolu/funding/gpay
branch
from
7ed8343 to
fcc1d83
Compare
Comment on lines
+699
to
+700
| cardFundingFilter = DefaultCardFundingFilter, | ||
| cardBrandFilter = DefaultCardBrandFilter |
Collaborator
There was a problem hiding this comment.
Might be worth a code comment, as this feels relevant long term.
| "allowedAuthMethods": ["PAN_ONLY", "CRYPTOGRAM_3DS"], | ||
| "allowedCardNetworks": ["AMEX", "DISCOVER", "MASTERCARD", "VISA"] | ||
| "allowedCardNetworks": ["AMEX", "DISCOVER", "MASTERCARD", "VISA"], | ||
| "allowCreditCards": true, |
Collaborator
There was a problem hiding this comment.
This is my only FUD with this PR.
Can you manually test to make sure no unexpected behavior changes happen as a result of us sending true here.
Contributor
Author
There was a problem hiding this comment.
Yh, I'm able to get it working for the Google Pay Button, but the Google Pay Sheet isn't adhering to this setting (even after hardcoding it). It always shows both credit and debit cards. I'm confirming with @samer-stripe to see if it's something we can only test in a Prod Google Pay environment.
Credit Cards Disabled (Google Pay Button)
Credit Cards Enabled (Google Pay Button)
Google Pay Sheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Filter by funding type in Google Pay
Motivation
Testing
Screenshots
Changelog