-
-
Notifications
You must be signed in to change notification settings - Fork 3
Created shared STTP code implementation for GSF and Gemstone library targets #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ritchiecarroll
wants to merge
64
commits into
master
Choose a base branch
from
gemstone
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,734
−5,546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lause with SQLite
ritchiecarroll
commented
Sep 8, 2025
Member
Author
ritchiecarroll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
…lter output measurements is true
UI Update For Adapter Rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update creates two primary projects:
sttp.gsfandsttp.gemstone, where both projects use the same shared code projectsttp.core. The goal with this update is to use the "same" STTP code for both GSF and Gemstone to reduce or eliminate code duplication and diversion.Most code library
usingreferences were migrated toglobal usingstatements that are defined within the corresponding primary projects. For the most part, this step solves the issue of using the same base code for both GSF and Gemstone, allowing two different assemblies, targeting two different .NET platforms, to be created from the same source code using independent code libraries.In places where library code was incompatible, a compile time conditional directive is used, e.g.:
The highest concentration of these directives is in
DataSubsciber- but there are only around 15 of them in the entire project, so they do not distract from code readability, IMO.Use the
Developmentsolution configuration to build this project with code-level access to Gemstone libraries.Note that using the
Developmentsolution configuration requires a project directory structure setup like the following:Root organization repo names are not critical, but relative path locations and referenced repo names, i.e.,
Gemstoneproject folder names, are important.I do not want to merge this PR until Gemstone nightly build is verified to be building NuGet targets and both GSF and Gemstone automated builds have been verified to properly work - may need to adjust build operation to handle dual outputs. Also, want to do a little testing first, such as with EE work, to ensure code is working as expected.
Also, may want both a "dev" solution that includes Gemstone relative project references as well as a normal solution, without these references and without a
Developmentsolution target, i.e., a separate solution which only targets NuGet package references that can be used with automatic build.