fix: update return types and handle null values in PaygQueryService and PaygService#639
fix: update return types and handle null values in PaygQueryService and PaygService#639
Conversation
📝 WalkthroughWalkthroughBumps indexer-coordinator to 2.10.5, changes the package Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/indexer-coordinator/src/payg/payg.service.ts`:
- Around line 174-188: The updateChannelFromNetwork function treats null as
falsy and re-fetches the channel, losing the explicit "not found" signal; change
the guard that currently reads if (!altChannelData) so it only triggers a
network fetch when altChannelData === undefined (i.e., check for undefined
explicitly), leaving altChannelData === null untouched so the "not found" case
is honored and deletion logic can run; update references in
updateChannelFromNetwork to use this strict undefined check.
Summary by CodeRabbit
Version Update
Bug Fixes
Chores