Support Douglas Crockford's Base32 and add option to split result #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading https://sudhir.io/uuids-ulids, I found it interesting to support Douglas Crockford's Base32. The default is still the gem's original `DEFAULT_BASE62`, but it's easy for the user invoke Douglas's alphabet by either passing it as an argument (like ShortUUID.shorten(string, ShortUUID::DOUGLAS_CROCKFORD_BASE32) or set the new default in an Rails initializer for instance. I also froze the '-' string and added the support for splitting the result string (makes it even easier to say it on the phone).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading https://sudhir.io/uuids-ulids, I found it interesting to support Douglas Crockford's Base32.
The default is still the gem's original
DEFAULT_BASE62, but it's easy for the user invoke Douglas's alphabet by either passing it as an argument (like ShortUUID.shorten(string, ShortUUID::DOUGLAS_CROCKFORD_BASE32) or set the new default in an Rails initializer for instance.I also froze the '-' string and added the support for splitting the result string (makes it even easier to say it on the phone).