Skip to content

GitHub Actions Automated Test#539

Closed
muchemicarol wants to merge 1 commit intosunlabuiuc:masterfrom
muchemicarol:fix-automated-tests-with-GitHub-Actions
Closed

GitHub Actions Automated Test#539
muchemicarol wants to merge 1 commit intosunlabuiuc:masterfrom
muchemicarol:fix-automated-tests-with-GitHub-Actions

Conversation

@muchemicarol
Copy link

Included an action to automate running of tests.

@jhnwu3 jhnwu3 requested a review from plandes September 10, 2025 20:12
@jhnwu3
Copy link
Collaborator

jhnwu3 commented Sep 10, 2025

Poking @plandes here, since iirc we have an automated set of tests already setup in the makefile

@plandes
Copy link
Collaborator

plandes commented Sep 10, 2025

@muchemicarol, @jhnwu3 sorry, but this change should be rejected. Non-NLP tests should be added as:
PyHealth/tests/core/test_<your test name>.py

If your test has a new requirement that's needed both in the code and the test, append to the project.dependencies in the pyproject.toml file.

If your test has a new requirement only needed for the test itself, append to the tool.pixi.feature.test.pypi-dependencies TOML table in the pyproject.toml file.

The tests are run with either make testall or pixi run test && pixi run testnlp.

@jhnwu3 jhnwu3 closed this Sep 10, 2025
@muchemicarol
Copy link
Author

Hey @jhnwu3, @plandes thanks for the feedback. It was a GitHub Action to run all tests (not a targeted NLP or Non-NLP test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants