Conversation
plandes
approved these changes
Sep 12, 2025
dalloliogm
pushed a commit
to dalloliogm/PyHealth
that referenced
this pull request
Nov 26, 2025
Co-authored-by: John Wu <johnwu3@sunlab-serv-03.cs.illinois.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
MLPmodel inpyhealth/models/mlp.pyto support the newSampleDatasetformat and simplifies the model's interface and feature handling. It also adds support for a new processor type in the embedding model and improves code clarity and maintainability throughout. The most important changes are grouped below:Dataset and Model Interface Modernization:
MLPmodel to useSampleDatasetinstead ofSampleEHRDataset, updating constructor arguments and usage examples for a simpler and more unified interface. Feature and label keys are now inferred from the dataset, removing the need to manually specify them. [1] [2] [3] [4] [5]Feature Handling and Forward Logic Simplification:
forwardmethod inMLPto dynamically handle different feature types and tensor shapes, including automatic creation of embedding or linear layers as needed, and streamlined pooling logic for both categorical and numerical inputs.Processor and Embedding Model Extension:
TensorProcessorin the embedding model, enabling flexible handling of tensor-based features by automatically determining input size from sample data. [1] [2]Documentation and Code Clarity:
MLPmodel, including more detailed explanations of supported input formats and pooling methods. [1] [2]Miscellaneous Improvements: