Merged
Conversation
dalloliogm
pushed a commit
to dalloliogm/PyHealth
that referenced
this pull request
Nov 26, 2025
* use new EmbeddingModel approach * updated test case to reflect variability in data --------- Co-authored-by: John Wu <johnwu3@sunlab-serv-03.cs.illinois.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
MLPmodel inpyhealth/models/mlp.pyto simplify and centralize the embedding logic by introducing the newEmbeddingModelclass. The changes improve maintainability and make the handling of different input types more consistent and modular.Model architecture refactoring
MLPmodel with a dedicatedEmbeddingModelclass for handling all embedding logic, reducing code duplication and complexity. [1] [2]forwardmethod to preprocess inputs, track reshaping information, and delegate embedding operations toEmbeddingModel, followed by pooling and concatenation of patient embeddings. [1] [2] [3]Test data update
tests/core/test_mlp.pyto add an additional condition to the input data, ensuring coverage of the updated embedding handling.