Standard forward_from_embedding in BaseModel#821
Merged
jhnwu3 merged 56 commits intosunlabuiuc:masterfrom Feb 10, 2026
Merged
Conversation
…ard_from_embedding
…ard_from_embedding
jhnwu3
approved these changes
Feb 10, 2026
Collaborator
jhnwu3
left a comment
jhnwu3
left a comment
There was a problem hiding this comment.
lgtm. We can iterate if need be.
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three new methods
forward,forward_from_embedding,get_embedding_model.This breaks the old
forward_from_embedding, but make it more mimic towardsforward. This should make the API a bit cleaner to avoid a bunch of random named args, but does mean all interpertability methods need to update according to new APIFix #818.
Models
Interpretability
Chefer(Deferred to next PR due to coupling with attention)