Fix flaky test_gradient_flow in JambaEHR (#855)#857
Merged
jhnwu3 merged 1 commit intosunlabuiuc:masterfrom Feb 16, 2026
Merged
Conversation
joshuasteier
force-pushed
the
fix/jamba-gradient-test
branch
from
e51e62d to
3628272
Compare
Logiquo
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #855
Problem:
test_gradient_flowinTestJambaLayerfails intermittently because random initialization can produce zero gradients through Mamba's selective scan path.Fix: Added
torch.manual_seed(42)before layer construction and input generation to make the test deterministic. Verified stable across multiple consecutive runs.Files changed:
tests/core/test_jamba_ehr.py(1 line added)