rubocop add configuration for nonzero and safe navigation #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specs: Remove spec for Money#pence which doesn’t exist
Before: > Randomized with seed 53114 > .........................................................................................................................................[WARNING] Using :ruby format when importing rates is potentially unsafe and might lead to remote code execution via Marshal.load deserializer. Consider using safe alternatives such as :json and :yaml. > ........................................................................................................................................................................................................................................................................................................................................................................................... After: > Randomized with seed 30224 > .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Also moved a few RSpec configuration into their own support files in order to have a more readable RSpec configuration.
…d-link Replace Inch CI docs link with GitHub Pages version
…n-formatting-rules remove deprecated formatting rules
…rency-differs Warn when using `#eql?` on zero amounts with different currencies
…s-on-non-dollars Deprecate `Money#dollars` and `Money.from_dollars`
Adjust formatting rules to use i18n translations for `:format`
Co-authored-by: Sunny Ripert <sunny@sunfox.org>
Co-authored-by: Sunny Ripert <sunny@sunfox.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
`default_currency` is no longer USD
Silence deprecation warning in specs
- Remove Money.use_i18n and Money.use_i18n= methods - Remove legacy locale backend implementation - Change default locale backend from :i18n to :currency - Fix tests to explicitly set :i18n backend where needed - Fix arithmetic tests timing issue with around blocks - Update CHANGELOG to document breaking changes
"Gulden" is part of the Dutch name "Antilliaanse gulden". The English name is "Netherlands Antillean guilder". Also note that officially it's styled with lowercase "guilder" [1,2] but opting for "Guilder" to be consistent with the title-case naming style of other currencies in this library. [1]: https://www.centralbank.cw/functions/banknotes-coins/caribbean-guilder [2]: https://www.centralbank.cw/storage/app/media/caribbean_guilder/20250404_caribbean_guilder_introduction_flyer_english.pdf
sunny
force-pushed
the
rubocop-add-configuration-for-nonzero-and-safe-navigation
branch
from
11c6bcd to
812c3e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Money#dollarswhen the currency is not USD#eql?will return false if the currency differs, even for zero.:format#nonzero?