Skip to content

Release/3.0.0#894

Open
tomwojcik wants to merge 37 commits intomigrate-to-pytest-2from
release/3.0.0
Open

Release/3.0.0#894
tomwojcik wants to merge 37 commits intomigrate-to-pytest-2from
release/3.0.0

Conversation

@tomwojcik
Copy link
Contributor

No description provided.

tomwojcik and others added 26 commits May 3, 2024 17:10
# Conflicts:
#	pyproject.toml
#	testproject/testapp/tests/test_password_reset.py
#	testproject/testapp/tests/test_resend_activation.py
#	testproject/testapp/tests/test_reset_username.py
#	testproject/testapp/tests/test_set_username.py
#	testproject/testapp/tests/test_user_create.py
#	testproject/testapp/tests/test_user_delete.py
#	testproject/testapp/tests/test_user_detail.py
@tomwojcik tomwojcik changed the base branch from master to migrate-to-pytest-2 July 28, 2025 14:18
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 99.46714% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.18%. Comparing base (1d4bdd0) to head (38a3c15).

Files with missing lines Patch % Lines
djoser/views/user/base.py 92.85% 2 Missing ⚠️
djoser/views/user/update_put.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           migrate-to-pytest-2     #894      +/-   ##
=======================================================
+ Coverage                98.67%   99.18%   +0.50%     
=======================================================
  Files                       27       60      +33     
  Lines                      908     1224     +316     
=======================================================
+ Hits                       896     1214     +318     
+ Misses                      12       10       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@haxoza haxoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dispatcher mechanizm looks a bit complicated, but do I get it correctly that it is the cost of splitting the "god" view and keeping the API the same?

method = request.method
if method in method_view_map:
view_class = method_view_map[method]
return view_class.as_view()(request, *args, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to support function based views?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants