Skip to content

Conversation

@timkendrick
Copy link

@timkendrick timkendrick commented Oct 31, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Exposed GraphQL schema exposes a nullable type for pagable collection wrapper objects

What is the new behavior?

The schema type is now a non-null type

Additional context

note the ! annotations in the collection return types

Before After
image image

@olirice olirice requested a review from imor November 11, 2025 20:36
@olirice
Copy link
Contributor

olirice commented Nov 11, 2025

@imor @alaister i think that's safe b/c it was always impossible for it to return null
some codegen tools may break but overall seems fine. wdyt?

@olirice olirice requested a review from alaister November 11, 2025 20:38
@imor
Copy link
Contributor

imor commented Nov 12, 2025

@olirice Sounds good to me. @timkendrick could you please fix the failing tests.

@timkendrick timkendrick force-pushed the non-null-collection-type branch from 78f1ca4 to fecdefe Compare November 12, 2025 17:38
@timkendrick
Copy link
Author

Thanks @olirice @imor

I've pushed an update that fixes the installcheck test suite, let me know if there's anything else I need to do

@timkendrick timkendrick force-pushed the non-null-collection-type branch from fecdefe to 063f49b Compare November 12, 2025 18:37
@imor imor merged commit 7951d27 into supabase:master Nov 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants