Transpiler re-write to use an AST vs string concatenation #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der trait, restrict Expr::Raw to tests
- Adds native_param module with type-safe parameter binding - Uses native PostgreSQL types where safe (bool, int, float, text) - Falls back to text-based binding for custom types, arrays, and edge cases - Includes comprehensive pg_regress test for edge cases - Maintains full backwards compatibility with existing behavior
The null handling in cursor pagination was incorrectly building different expressions based on nulls_first. The original transpiler uses nulls_first as a boolean literal (AND true/AND false), not as a condition selector. Also restores the original expected test output that was incorrectly modified.
…dering Tests cover: - NULLS FIRST vs NULLS LAST with ASC ordering - NULLS FIRST vs NULLS LAST with DESC ordering - Forward pagination (first/after) across null boundaries - Reverse pagination (last/before) across null boundaries - Edge cases at null-to-non-null transition points
- Fix float4 (real) type using text fallback instead of native binding to avoid f64->f32 size mismatch corruption - Add run_tests.sh script for easy pg_regress testing - Add expected output for cursor_pagination_nulls and native_param_binding tests - Update CLAUDE.md to emphasize pg_regress as primary test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Major refactor of the transpiler. More structure is a good improvement here, but its mainly in prep for nested inserts. Might get to that over the Christmas break.
In draft. I need to review it again as its been a few days since writing and is huge