feat: add older versions of the wrappers extension
#1748
Conversation
yvan-sraka
changed the title
wrappers extensionwrappers extension
yvan-sraka
force-pushed
the
multi-version-ext/wrappers-v0.2.0
branch
from
ecf641f to
ff4cef2
Compare
yvan-sraka
force-pushed
the
custom-github-runners
branch
16 times, most recently
from
1eb74b8 to
db1e5e4
Compare
jfroche
force-pushed
the
custom-github-runners
branch
8 times, most recently
from
0878bd2 to
b842e89
Compare
jfroche
force-pushed
the
custom-github-runners
branch
7 times, most recently
from
b500264 to
229115e
Compare
yvan-sraka
force-pushed
the
custom-github-runners
branch
from
229115e to
4947f52
Compare
yvan-sraka
force-pushed
the
multi-version-ext/wrappers-v0.2.0
branch
from
ff4cef2 to
21ade98
Compare
yvan-sraka
changed the title
wrappers extensionwrappers extension
yvan-sraka
force-pushed
the
multi-version-ext/wrappers-v0.2.0
branch
from
21ade98 to
8c1a800
Compare
yvan-sraka
force-pushed
the
multi-version-ext/wrappers-v0.2.0
branch
from
8c1a800 to
b8a95f8
Compare
yvan-sraka
force-pushed
the
multi-version-ext/wrappers-v0.2.0
branch
from
b8a95f8 to
8533f41
Compare
yvan-sraka
changed the title
wrappers extensionwrappers extension
| }; | ||
| } | ||
| // lib.optionalAttrs (version == "0.3.0") { | ||
| patches = [ ./0001-bump-pgrx-to-0.11.3.patch ]; |
There was a problem hiding this comment.
We do the same change for versions <= 0.3.0, maybe there is a way to have one condition here ?
I guess it will be the same for the older versions (0.1.7 -> 0.1.14) that are not here yet.
There was a problem hiding this comment.
Actually I didn't patch pgrx for older versions, and I consider even in the end to not patch it for 0.2.0 or 0.3.0 and to rather add more versions to nix/cargo-pgrx/versions.json, WDYT?
There was a problem hiding this comment.
If the whole block is the same (including the cargo lock file and/or the patch) for all versions <= 0.3.0 we should only have 1 block
There was a problem hiding this comment.
We might want to move it to nix/ext/scripts instead so that nix/ext only contains the extensions
| @@ -0,0 +1,90 @@ | |||
| #! /usr/bin/env nix-shell | |||
| #! nix-shell -i python3 -p python3 git nix-prefetch-git python3Packages.packaging | |||
|
|
|||
There was a problem hiding this comment.
Add a few lines of documentation on what is does and maybe an example of how we can use it
There was a problem hiding this comment.
Yes indeed, should I put that in nix/docs/adding-new-package.md or nix/docs/update-extension.md or both?
There was a problem hiding this comment.
adding-new-package.md needs a complete rewrite, I would add it in update-extension.md first and do another PR/TODO for improving overall documentation (removing the old way) on how to create/update multi version extensions
yvan-sraka
force-pushed
the
multi-version-ext/wrappers-v0.2.0
branch
2 times, most recently
from
6f89146 to
fa4bd0d
Compare
... which is handy when it comes to compute hashes for every source tarball in a bulk :)
yvan-sraka
force-pushed
the
multi-version-ext/wrappers-v0.2.0
branch
from
fa4bd0d to
6323605
Compare
This PR add a few commits on top of #1743