Skip to content

refactor(ansible): bring our ansible up to modern ansible-lint standards #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Nov 5, 2025
Merged

refactor(ansible): bring our ansible up to modern ansible-lint standards #1881

merged 27 commits into from
Nov 5, 2025
+94 −77

Conversation

@hunleyd
Copy link
Contributor

@hunleyd hunleyd commented Oct 30, 2025

The 17th (of 17) in a series of PRs, going file-by-file cleaning up and modernizing our Ansible to make current ansible-lint happy as well as following https://redhat-cop.github.io/automation-good-practices/

hunleyd added 27 commits October 27, 2025 13:04
@hunleyd
refactor(ansible): bring our ansible up to modern ansible-lint standards
fa85934
@hunleyd
fix(stage2-setup-postgres): typo fixup
309d4fd
@hunleyd
fix(stage2-setup-postgres): lazy eval means we trip over variable nam…
f673e00 
…ing rules
@hunleyd
fix(stage2-setup-postgres): more playing w/ the variable evaluation
113abe7
@hunleyd
fix(stage2-setup-postgres): fine, you win. we won't loop, and we'll d…
b9ec118 
…o it the long, slow ass way
@hunleyd
fix(stage2-setup-postgres): when moving stuff around it hekps to move…
f634b88 
… loop_var with it. sigh
@hunleyd
fix(stage2-setup-postgres): not sure how i munged that path so badly.…
c22b0a3 
… i blame the drugs
@hunleyd
fix(stage2-setup-postgres): force overwriting
cb12bb5
@hunleyd
fix(stage2-setup-postgres): stop making things harder and just symlin…
8caec8b 
…k parent dirs
@hunleyd
fix(stage2-setup-postgres): nuke the dir so we can recreate it as a s…
ecaabda 
…ymlink
@hunleyd
test(test-image): cat the pg conf file to stdout so i can see wtf is …
cbd5986 
…going on
@hunleyd
test(test-image): don't let nvim autocomplete conf to config, damnit
fccdaaa
@hunleyd
fix(stage2-setup-postgres): the replacement isn't a regex so don't tr…
ef92862 
…eat it as one
@hunleyd
test(test-image): remove my debug output s things are sorted out now
452bce8
@hunleyd
Merge remote-tracking branch 'origin' into ansible_cleanups
7d2f6cb 
* origin:
  refactor(ansible): bring our ansible up to modern ansible-lint standards (#1869)
  feat: update supautils (#1879)
  feat: support multiple versions of the plv8 extension (#1676)
  chore: bump wrappers version 0.5.6 (#1877)
  feat: support multiple versions of the pg_hashids extension (#1755)
  fix: covering migrations for wrappers across all versions` (#1876)
  feat(Nix-flakes): Add pgBackRest flake (#1859)
  fix: wrappers 0.5.3 missing (#1872)
@hunleyd
refactor(ansible): bring our ansible up to modern ansible-lint standards
f0f2a64
@hunleyd
fix(test-image): remove errant double quote
49c832c
@hunleyd
fix(test-image): typo fix
5099b3f
@hunleyd
Merge remote-tracking branch 'origin' into ansible_cleanups
5007446 
* origin:
  feat: enable GitHub merge queues (#1849)
@hunleyd
fix(test-image): le sigh. mandatory args are mandatory
b5855ea
@hunleyd
Merge branch 'develop' of github.com:supabase/postgres into ansible_c…
5e2ecf6 
…leanups

* 'develop' of github.com:supabase/postgres:
  fix: change trigger to `merge_group` in "Release Migrations - Staging / build (push)" workflow (#1884)
  tests: newline readme (#1883)
@hunleyd
fix(test-image): thinko. we should be looking for the regex to be rem…
1d1f7cc 
…oved, not present
@hunleyd
fix(test-image): a double ** is a no-no, and removing it makes the 2 …
6531bed 
…lines identical, so nuke the one line
@hunleyd
fix(test-image): community.postgresql needs psycopg2
3a7bb75
@hunleyd
fix(test-image): restart PG and then try resetting stats
a8b6e31
@hunleyd
fix(test-image): put the reset task where it was and just skip pg_sta…
634978e 
…t_statements when resetting
@hunleyd
Merge branch 'develop' into ansible_cleanups
210e997
@hunleyd hunleyd marked this pull request as ready for review November 1, 2025 22:42
@hunleyd hunleyd requested review from a team as code owners November 1, 2025 22:42
jchancojr
jchancojr approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@jchancojr jchancojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jchancojr jchancojr added this pull request to the merge queue Nov 5, 2025
Merged via the queue into develop with commit 55ae020 Nov 5, 2025
14 checks passed
@jchancojr jchancojr deleted the ansible_cleanups branch November 5, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samrose samrose samrose approved these changes

@jchancojr jchancojr jchancojr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hunleyd @samrose @jchancojr