feat: add storage settings support #260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savme
reviewed
Nov 29, 2025
| return diag.Diagnostics{diag.NewErrorDiagnostic("Client Error", msg)} | ||
| } | ||
|
|
||
| if state.Storage, err = parseConfig(state.Storage, *httpResp.JSON200); err != nil { |
Collaborator
There was a problem hiding this comment.
Does parseConfig work with storage as expected? I believe parseConfig does not handle nested structures at the moment, so icebergCatalog being omitempty might cause issues with the state. Could you take a look and confirm?
Contributor
Author
There was a problem hiding this comment.
Good call, wrote a unit test for the icebergCatalog case and it did drop the field when the API omitted it. pickConfig now recurses into nested structs and preserves user values even when the response has omitempty. Added the test to make sure we don’t regress.
JEETDESAI25
force-pushed
the
feat/issue-227-storage-settings
branch
from
5345858 to
6d718e2
Compare
JEETDESAI25
force-pushed
the
feat/issue-227-storage-settings
branch
from
6d718e2 to
5ff60cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Closes #227. supabase_settings.storage existed in the schema but wasn’t wired to the Supabase API, so users couldn’t configure storage limits or feature flags and Terraform ignored the input.
What is the new behavior?
Additional context
Storage logic mirrors the existing database/network/api/auth patterns. PR #258 plan-vs-state comparison pattern can be extended to include storage.