Skip to content

Conversation

@sujaygijre
Copy link

Please review

@super30admin
Copy link
Owner

  • Strengths:
    • Correct implementation of binary search for rotated sorted arrays.
    • Good use of comments to explain the approach.
    • Proper handling of edge cases (e.g., checking if the left half is sorted).
  • Areas for Improvement:
    • The student included solutions for unrelated problems (unknown size array and 2D matrix) which were not part of the evaluation. Focus on the specific problem being evaluated.
    • The comments could be more concise. For example, the numbered list in the comments could be simplified to a brief overview of the approach.
    • The space complexity comment in the 2D matrix solution is incorrect (should be O(1), not O(mn)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants