Skip to content

Conversation

@rbhargav0104
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The code is well-commented and easy to understand.
    • The solutions for 2dmatrixsearch.cpp and ul-sortedarraysearch.cpp are correct and efficient.
    • Good use of binary search logic and handling of edge cases in most parts.
  • Areas for Improvement:
    • In rsortedarray.cpp, the loop condition while (low < high) should be while (low <= high) to ensure all edge cases are covered. The current implementation might miss cases where the target is at the low == high position.
    • The comment in rsortedarray.cpp about the edge case where low == high is correct, but the loop condition should be adjusted to include this case within the loop for consistency and completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants