Skip to content

Conversation

@melvinmilkiyas
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • Good understanding of the MinStack problem and correct implementation.
  • Clear comments and explanations.
  • Proper use of data structures to achieve O(1) time complexity.

Areas for Improvement:

  • The MyHashSet implementation needs to be corrected to use boolean flags instead of storing keys. This will ensure the contains method works correctly.
  • The MyHashSet solution should handle edge cases better, such as when the key is 0 or when the bucket size is not optimal.
  • Consider using more descriptive variable names in the MinStack solution to improve readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants