Done with Design-1 #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Mukul585 wants to merge 1 commit into super30admin:master from Mukul585:master

Mukul585 commented Dec 24, 2025

No description provided.


          Done Design-1

cf536fa

Owner

super30admin commented Dec 24, 2025

Strengths:

The student has clearly understood the problem and implemented the solutions correctly.
The use of double hashing in MyHashSet and auxiliary stack in MinStack is well-executed.
Code is clean, with good variable naming and appropriate comments.

Areas for Improvement:

In the MinStack implementation, the pop operation could be made more robust by checking if the stack is empty before popping, though the problem constraints might not require it.
The comments could be slightly more detailed to explain why certain choices were made (like the bucket size of 1000).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet