Skip to content

Conversation

@melvinmilkiyas
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The hash map implementation is well-done, with clear separation of concerns and good use of a linked list for handling collisions.
  • The queue implementation follows the correct approach of using two stacks.
  • The code is commented and easy to follow.

Areas for Improvement:

  • In the queue implementation, the pop method should return -1 when the queue is empty to match the reference solution's behavior.
  • The peek method in the queue implementation could also return -1 when the queue is empty for consistency.
  • The comments in the hash map implementation are helpful but could be more concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants