Implemented Design-2 #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sneha-tambade wants to merge 1 commit into super30admin:master from sneha-tambade:implement-Design-2

sneha-tambade commented Dec 26, 2025

No description provided.


          Implemented Design-2

9ab2ade

Owner

super30admin commented Dec 26, 2025

Strengths:

The student has correctly implemented the queue using two stacks, demonstrating a good understanding of the problem.
The code is clean, well-commented, and follows good practices.
The time and space complexity analysis is accurate.

Areas for Improvement:

The Console.WriteLine(outStack.Peek()); in the Peek method seems unnecessary for the functionality and could be removed to avoid side effects.
While the comments are helpful, they could be more detailed to explain why the two-stack approach works (FIFO using LIFO structures).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet