fix(super-editor): guard against style definition nodes without elements#2379
Open
luccas-harbour wants to merge 1 commit intomainfrom
Open
Conversation
e8bc23f to
19a8cab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents getDefaultStyleDefinition() from crashing when a matching style node exists in word/styles.xml but does not contain an elements array.
What changed
definition shape
Why
Some DOCX inputs can include a style definition node with the expected w:styleId but without child elements. Before this change, the helper assumed firstMatch.elements always existed and could throw while traversing the style definition. This makes the converter more defensive and preserves the existing fallback behavior for incomplete style data.