Skip to content

Conversation

@Ban1p7
Copy link

@Ban1p7 Ban1p7 commented Feb 1, 2025

Remove squash and invulnerability stars after goal
Issue #5108

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

remove squash and invulnerability starts after goal
@Alayan-stk-2
Copy link
Member

Thank you for the PR!

However:

  • it would be better to do a deeper reset with a call to a dedicated kart function. For example, attachments (bombs, swatters...) also currently persist and should arguably not.
  • This won't be merged before 1.5 is out.

Moved everything into a separate kart function
@Alayan-stk-2 Alayan-stk-2 changed the base branch from master to BalanceSTK2 November 16, 2025 16:05
@Alayan-stk-2
Copy link
Member

I looked at getting a clean merge, but that appeared way too complicated. In the end it was much simpler to copy over the relevant changes and to add my own further changes on top.

So I'm closing this PR, but I gave you credit as co-author in the commit : e843eab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants