Closed
Conversation
Contributor
|
Warning Rate limit exceeded@supervoidcoder has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new GitHub Actions workflow file that runs Windows-based runtime tests for the win-witr executable: checks out code, sets up MSVC, builds the binary, runs multiple PowerShell-driven test groups (help/version, PID/process checks, output validation, stress/Unicode tests), and posts a PR comment with results. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions Runner
participant Repo as Repository (checkout)
participant MSVC as MSVC Toolchain
participant Bin as win-witr executable
participant PS as PowerShell test script
participant PR as GitHub PR API
GH->>Repo: checkout code
GH->>MSVC: setup MSVC environment
GH->>MSVC: build `win-witr`
MSVC-->>GH: build artifact / exit status
GH->>PS: initialize test results file
loop For each test group
GH->>Bin: invoke with specific flags/inputs
Bin-->>PS: stdout/stderr, exit codes
PS->>GH: update results file with ✅/❌
end
GH->>GH: print final banner & results
GH->>PR: post PR comment with aggregated table
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In @.github/workflows/runtime-tests.yml:
- Around line 256-273: The runtime-tests-elevated job (runtime-tests-elevated)
currently only builds the binary in the "Build win-witr" step and prints a note,
so add a step that actually executes elevated tests or remove the job; to fix,
either (A) add a step after "Build win-witr" that runs the executable under
elevated context and executes your privileged test suite (e.g., a PowerShell
step that invokes win-witr.exe with test flags and captures exit codes/logs, or
uses Start-Process -Verb RunAs to request elevation) and include failure
handling, or (B) if you don't have elevated tests yet, delete the
runtime-tests-elevated job (and any references) to avoid a no-op CI entry;
reference the job name runtime-tests-elevated and the "Build win-witr" step when
applying the change.
- Around line 67-80: The two steps named "Test --pid with System Idle Process
(PID 0)" and "Test --pid with System process (PID 4)" currently pipe all output
to Out-Null so failures are ignored; change each step to capture stdout/stderr
(e.g., redirect to a temp variable or file instead of Out-Null), then inspect
$LASTEXITCODE and fail the step when it is non-zero (or conditionally accept
specific known permission-related exit codes), and write the captured output
with Write-Host/Write-Error before exiting so the workflow fails on real errors
(also add a quick existence check for ./win-witr.exe before invoking to catch
missing binary).
- Around line 266-269: The "Build win-witr" step uses the cl invocation in the
workflow but omits required Windows libraries; update the cl command (the line
invoking cl /O2 /std:c++20 /EHsc main.cpp /DUNICODE /D_UNICODE /Fe:win-witr.exe)
to include the linker inputs advapi32.lib iphlpapi.lib ws2_32.lib shell32.lib so
the build links Windows API dependencies and avoids linker errors.
🧹 Nitpick comments (1)
.github/workflows/runtime-tests.yml (1)
190-211: Validation logic is too permissive.Both tests use weak validation patterns:
- Lines 195-196: Only checks if output contains "PID" rather than verifying tree structure (e.g., indentation, tree characters like └, ├)
- Lines 206-207: Only checks if output contains "ago" rather than validating timestamp format (e.g., matching a date pattern)
These tests could pass even with malformed output.
♻️ Proposed stronger validation patterns
- name: Test ancestry tree formatting run: | Write-Host "Testing ancestry tree formatting..." -ForegroundColor Cyan $output = ./win-witr.exe --pid $PID | Out-String - # Check for tree-like structure - if ($output -match "PID") { + # Check for tree-like structure with indentation or tree characters + if ($output -match "PID.*\d+" -and ($output -match "├|└|│" -or $output -match "\s{2,}")) { Write-Host "✅ Ancestry tree formatting passed" -ForegroundColor Green } else { throw "❌ Ancestry tree not properly formatted" } - name: Test timestamp format run: | Write-Host "Testing timestamp format..." -ForegroundColor Cyan $output = ./win-witr.exe --pid $PID | Out-String - # Should contain "ago" and a date - if ($output -match "ago") { + # Should contain relative time (e.g., "5 minutes ago") or date pattern + if ($output -match "\d+\s+(second|minute|hour|day|week|month|year)s?\s+ago" -or $output -match "\d{4}-\d{2}-\d{2}") { Write-Host "✅ Timestamp format passed" -ForegroundColor Green } else { throw "❌ Timestamp format incorrect" }
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/runtime-tests.yml
🧰 Additional context used
🪛 GitHub Check: CodeQL
.github/workflows/runtime-tests.yml
[warning] 11-256: Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
[warning] 257-273: Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
🔇 Additional comments (1)
.github/workflows/runtime-tests.yml (1)
20-26: LGTM!The build step correctly compiles with C++20 standard, includes necessary Windows libraries, and has proper error handling.
Owner
Author
|
@coderabbitai HELP WHY DEOS IT FAIL IT WORKS WITH G++ g++ -std=c++17 main.cpp -o win-witr -ladvapi32 -liphlpapi -lws2_32 -lshell32 -DUNICODE -D_UNICODE BUT NOT MSVC ANYMORE?!?!!? CAN YOU JUST GIVE ME FULL FIXED FILE PLS |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 11159 🏁 Script executed: Length of output: 21277 🏁 Script executed: Length of output: 8 @supervoidcoder I found the issue! 🎯 The problem is that your first job (runtime-tests) is missing the Unicode defines, but your second job (runtime-tests-elevated) already has them! The Issue:
Without these defines, Here's the fixed workflow file: name: Runtime Tests
on:
push:
branches: [ main, master ]
pull_request:
branches: [ main, master ]
jobs:
runtime-tests:
runs-on: windows-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@v1
- name: Build win-witr
run: |
cl.exe /EHsc /std:c++20 main.cpp /Fe:win-witr.exe advapi32.lib iphlpapi.lib ws2_32.lib shell32.lib /DUNICODE /D_UNICODE
if ($LASTEXITCODE -ne 0) {
throw "Build failed!"
}
# ============ HELP COMMAND TESTS ============
- name: Test --help flag
run: |
Write-Host "Testing --help flag..." -ForegroundColor Cyan
./win-witr.exe --help
if ($LASTEXITCODE -ne 0) {
throw "❌ Help command failed"
}
Write-Host "✅ --help passed" -ForegroundColor Green
- name: Test -h flag
run: |
Write-Host "Testing -h flag..." -ForegroundColor Cyan
./win-witr.exe -h
if ($LASTEXITCODE -ne 0) {
throw "❌ Short help failed"
}
Write-Host "✅ -h passed" -ForegroundColor Green
# ============ VERSION COMMAND TESTS ============
- name: Test --version flag
run: |
Write-Host "Testing --version flag..." -ForegroundColor Cyan
$output = ./win-witr.exe --version | Out-String
Write-Host $output
if ($output -notmatch "win-witr v\d+\.\d+\.\d+") {
throw "❌ Version format incorrect: $output"
}
Write-Host "✅ --version passed" -ForegroundColor Green
- name: Test -v flag
run: |
Write-Host "Testing -v flag..." -ForegroundColor Cyan
./win-witr.exe -v
if ($LASTEXITCODE -ne 0) {
throw "❌ Short version failed"
}
Write-Host "✅ -v passed" -ForegroundColor Green
# ============ PID INSPECTION TESTS ============
- name: Test --pid with System Idle Process (PID 0)
run: |
Write-Host "Testing --pid 0 (System Idle)..." -ForegroundColor Cyan
./win-witr.exe --pid 0 2>&1 | Out-Null
# May fail due to permissions, that's OK
Write-Host "✅ PID 0 test completed" -ForegroundColor Green
- name: Test --pid with System process (PID 4)
run: |
Write-Host "Testing --pid 4 (System)..." -ForegroundColor Cyan
./win-witr.exe --pid 4 2>&1 | Out-Null
# May fail due to permissions, that's OK
Write-Host "✅ PID 4 test completed" -ForegroundColor Green
- name: Test --pid with current PowerShell process
run: |
Write-Host "Testing --pid with current process ($PID)..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
Write-Host $output
if ($LASTEXITCODE -ne 0) {
throw "❌ Current process PID inspection failed"
}
if ($output -notmatch "Process Ancestry") {
throw "❌ Output missing 'Process Ancestry'"
}
Write-Host "✅ Current process PID test passed" -ForegroundColor Green
- name: Test --pid with explorer.exe
run: |
Write-Host "Testing --pid with explorer.exe..." -ForegroundColor Cyan
$explorerPid = (Get-Process explorer -ErrorAction SilentlyContinue | Select-Object -First 1).Id
if ($explorerPid) {
Write-Host "Found explorer.exe with PID: $explorerPid"
./win-witr.exe --pid $explorerPid
if ($LASTEXITCODE -ne 0) {
Write-Host "⚠️ Explorer access might be restricted" -ForegroundColor Yellow
}
} else {
Write-Host "⚠️ Explorer not running, skipping" -ForegroundColor Yellow
}
Write-Host "✅ Explorer test completed" -ForegroundColor Green
# ============ ERROR HANDLING TESTS ============
- name: Test --pid with invalid PID (99999)
run: |
Write-Host "Testing --pid with non-existent PID (99999)..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid 99999 2>&1 | Out-String
Write-Host $output
if ($LASTEXITCODE -eq 0) {
throw "❌ Should fail with non-existent PID"
}
Write-Host "✅ Invalid PID handling passed" -ForegroundColor Green
- name: Test --pid with non-numeric argument
run: |
Write-Host "Testing --pid with non-numeric argument..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid notanumber 2>&1 | Out-String
Write-Host $output
if ($LASTEXITCODE -eq 0) {
throw "❌ Should fail with non-numeric PID"
}
if ($output -notmatch "not a valid number") {
throw "❌ Missing proper error message"
}
Write-Host "✅ Non-numeric PID handling passed" -ForegroundColor Green
- name: Test --pid without argument
run: |
Write-Host "Testing --pid without argument..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid 2>&1 | Out-String
Write-Host $output
if ($LASTEXITCODE -eq 0) {
throw "❌ Should fail when --pid has no argument"
}
if ($output -notmatch "requires an argument") {
throw "❌ Missing 'requires argument' error"
}
Write-Host "✅ Missing argument handling passed" -ForegroundColor Green
# ============ PROCESS NAME LOOKUP TESTS ============
- name: Test process name with svchost.exe
run: |
Write-Host "Testing process name lookup for svchost.exe..." -ForegroundColor Cyan
$output = ./win-witr.exe svchost.exe 2>&1 | Out-String
Write-Host $output
if ($output -match "Process Name specified") {
Write-Host "✅ Found svchost.exe" -ForegroundColor Green
} else {
Write-Host "⚠️ Unexpected output format" -ForegroundColor Yellow
}
- name: Test process name with explorer.exe
run: |
Write-Host "Testing process name lookup for explorer.exe..." -ForegroundColor Cyan
./win-witr.exe explorer.exe 2>&1 | Out-Null
Write-Host "✅ Explorer lookup completed" -ForegroundColor Green
- name: Test process name with non-existent process
run: |
Write-Host "Testing with non-existent process name..." -ForegroundColor Cyan
$output = ./win-witr.exe totallyFakeProcess.exe 2>&1 | Out-String
Write-Host $output
if ($LASTEXITCODE -eq 0) {
throw "❌ Should fail for non-existent process"
}
if ($output -notmatch "Could not find process") {
throw "❌ Missing proper error message"
}
Write-Host "✅ Non-existent process handling passed" -ForegroundColor Green
# ============ OUTPUT FORMAT VALIDATION ============
- name: Validate PID output contains required fields
run: |
Write-Host "Validating output format..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
$requiredFields = @("Executable Path", "Process Ancestry", "Started")
foreach ($field in $requiredFields) {
if ($output -notmatch [regex]::Escape($field)) {
throw "❌ Output missing required field: $field"
}
}
Write-Host "✅ Output format validation passed" -ForegroundColor Green
- name: Test ancestry tree formatting
run: |
Write-Host "Testing ancestry tree formatting..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
# Check for tree-like structure
if ($output -match "PID") {
Write-Host "✅ Ancestry tree formatting passed" -ForegroundColor Green
} else {
throw "❌ Ancestry tree not properly formatted"
}
- name: Test timestamp format
run: |
Write-Host "Testing timestamp format..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
# Should contain "ago" and a date
if ($output -match "ago") {
Write-Host "✅ Timestamp format passed" -ForegroundColor Green
} else {
throw "❌ Timestamp format incorrect"
}
# ============ STRESS TESTS ============
- name: Rapid-fire stress test
run: |
Write-Host "Running stress test (50 rapid requests)..." -ForegroundColor Cyan
for ($i = 0; $i -lt 50; $i++) {
./win-witr.exe --pid $PID | Out-Null
if ($LASTEXITCODE -ne 0) {
throw "❌ Stress test failed at iteration $i"
}
}
Write-Host "✅ Stress test passed (50 iterations)" -ForegroundColor Green
- name: Test multiple running processes
run: |
Write-Host "Testing against multiple running processes..." -ForegroundColor Cyan
$processes = Get-Process | Where-Object { $_.Id -ne 0 -and $_.Id -ne 4 } | Select-Object -First 5
foreach ($proc in $processes) {
Write-Host " Testing PID $($proc.Id) ($($proc.Name))..."
./win-witr.exe --pid $proc.Id 2>&1 | Out-Null
}
Write-Host "✅ Multiple process test completed" -ForegroundColor Green
# ============ UNICODE HANDLING ============
- name: Test Unicode tree characters
run: |
Write-Host "Testing Unicode character handling..." -ForegroundColor Cyan
[Console]::OutputEncoding = [System.Text.Encoding]::UTF8
$output = ./win-witr.exe --pid $PID 2>&1 | Out-String
if ($LASTEXITCODE -ne 0) {
throw "❌ Unicode handling failed"
}
Write-Host "✅ Unicode test passed" -ForegroundColor Green
# ============ FINAL SUMMARY ============
- name: Test Summary
if: always()
run: |
Write-Host ""
Write-Host "========================================" -ForegroundColor Magenta
Write-Host " 🎉 RUNTIME TESTS COMPLETED! 🎉" -ForegroundColor Magenta
Write-Host "========================================" -ForegroundColor Magenta
Write-Host ""
# ============ ELEVATED PRIVILEGES TEST (separate job) ============
runtime-tests-elevated:
runs-on: windows-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@v1
- name: Build win-witr
run: |
cl.exe /EHsc /std:c++20 main.cpp /Fe:win-witr.exe advapi32.lib iphlpapi.lib ws2_32.lib shell32.lib /DUNICODE /D_UNICODE
- name: Note about elevation
run: |
Write-Host "Note: GitHub Actions runners have limited elevation capabilities" -ForegroundColor Yellow
Write-Host "Some system process access tests may be skipped" -ForegroundColor YellowThe only change needed: Added Now both jobs have consistent build commands and it should compile successfully with MSVC! ( . .)っ |
Owner
Author
|
@coderabbitai it works but can you do this: the ci "fails" when you get to the part where it's supposed to fail, leading to github (and possibly users) thinking that the ci failed because your code is broken (not because the workflow is broken) can you also just remove the "elevated test" because what's the point if it just freaking prints stuff and does nothing logs: |
Owner
Author
|
Run Write-Host "Testing --pid with non-existent PID (99999)..." -ForegroundColor Cyan Exception: D:\a_temp\6d718331-c90d-4ee1-a8ce-50e806dc009a.ps1:6 |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@supervoidcoder Got it! Let me read the current workflow and fix both issues: 🏁 Script executed: Length of output: 11180 @supervoidcoder Perfect! I see the issue - when commands are supposed to fail (like testing invalid PID), PowerShell treats the non-zero exit code as an error and fails the CI step. The fixes:
Here's your fixed workflow file: name: Runtime Tests
on:
push:
branches: [ main, master ]
pull_request:
branches: [ main, master ]
jobs:
runtime-tests:
runs-on: windows-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@v1
- name: Build win-witr
run: |
cl.exe /EHsc /std:c++20 main.cpp /Fe:win-witr.exe advapi32.lib iphlpapi.lib ws2_32.lib shell32.lib /DUNICODE /D_UNICODE
if ($LASTEXITCODE -ne 0) {
throw "Build failed!"
}
# ============ HELP COMMAND TESTS ============
- name: Test --help flag
run: |
Write-Host "Testing --help flag..." -ForegroundColor Cyan
./win-witr.exe --help
if ($LASTEXITCODE -ne 0) {
throw "❌ Help command failed"
}
Write-Host "✅ --help passed" -ForegroundColor Green
- name: Test -h flag
run: |
Write-Host "Testing -h flag..." -ForegroundColor Cyan
./win-witr.exe -h
if ($LASTEXITCODE -ne 0) {
throw "❌ Short help failed"
}
Write-Host "✅ -h passed" -ForegroundColor Green
# ============ VERSION COMMAND TESTS ============
- name: Test --version flag
run: |
Write-Host "Testing --version flag..." -ForegroundColor Cyan
$output = ./win-witr.exe --version | Out-String
Write-Host $output
if ($output -notmatch "win-witr v\d+\.\d+\.\d+") {
throw "❌ Version format incorrect: $output"
}
Write-Host "✅ --version passed" -ForegroundColor Green
- name: Test -v flag
run: |
Write-Host "Testing -v flag..." -ForegroundColor Cyan
./win-witr.exe -v
if ($LASTEXITCODE -ne 0) {
throw "❌ Short version failed"
}
Write-Host "✅ -v passed" -ForegroundColor Green
# ============ PID INSPECTION TESTS ============
- name: Test --pid with System Idle Process (PID 0)
run: |
Write-Host "Testing --pid 0 (System Idle)..." -ForegroundColor Cyan
./win-witr.exe --pid 0 2>&1 | Out-Null
# May fail due to permissions, that's OK
Write-Host "✅ PID 0 test completed" -ForegroundColor Green
- name: Test --pid with System process (PID 4)
run: |
Write-Host "Testing --pid 4 (System)..." -ForegroundColor Cyan
./win-witr.exe --pid 4 2>&1 | Out-Null
# May fail due to permissions, that's OK
Write-Host "✅ PID 4 test completed" -ForegroundColor Green
- name: Test --pid with current PowerShell process
run: |
Write-Host "Testing --pid with current process ($PID)..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
Write-Host $output
if ($LASTEXITCODE -ne 0) {
throw "❌ Current process PID inspection failed"
}
if ($output -notmatch "Process Ancestry") {
throw "❌ Output missing 'Process Ancestry'"
}
Write-Host "✅ Current process PID test passed" -ForegroundColor Green
- name: Test --pid with explorer.exe
run: |
Write-Host "Testing --pid with explorer.exe..." -ForegroundColor Cyan
$explorerPid = (Get-Process explorer -ErrorAction SilentlyContinue | Select-Object -First 1).Id
if ($explorerPid) {
Write-Host "Found explorer.exe with PID: $explorerPid"
./win-witr.exe --pid $explorerPid
if ($LASTEXITCODE -ne 0) {
Write-Host "⚠️ Explorer access might be restricted" -ForegroundColor Yellow
}
} else {
Write-Host "⚠️ Explorer not running, skipping" -ForegroundColor Yellow
}
Write-Host "✅ Explorer test completed" -ForegroundColor Green
# ============ ERROR HANDLING TESTS ============
- name: Test --pid with invalid PID (99999)
run: |
Write-Host "Testing --pid with non-existent PID (99999)..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
cmd /c "win-witr.exe --pid 99999 2>&1" > $null
$exitCode = $LASTEXITCODE
$output = cmd /c "win-witr.exe --pid 99999 2>&1"
Write-Host ($output -join "`n")
if ($exitCode -eq 0) {
throw "❌ Should fail with non-existent PID"
}
Write-Host "✅ Invalid PID handling passed" -ForegroundColor Green
- name: Test --pid with non-numeric argument
run: |
Write-Host "Testing --pid with non-numeric argument..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
$output = cmd /c "win-witr.exe --pid notanumber 2>&1"
$exitCode = $LASTEXITCODE
Write-Host ($output -join "`n")
if ($exitCode -eq 0) {
throw "❌ Should fail with non-numeric PID"
}
if (($output -join " ") -notmatch "not a valid number") {
throw "❌ Missing proper error message"
}
Write-Host "✅ Non-numeric PID handling passed" -ForegroundColor Green
- name: Test --pid without argument
run: |
Write-Host "Testing --pid without argument..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
$output = cmd /c "win-witr.exe --pid 2>&1"
$exitCode = $LASTEXITCODE
Write-Host ($output -join "`n")
if ($exitCode -eq 0) {
throw "❌ Should fail when --pid has no argument"
}
if (($output -join " ") -notmatch "requires an argument") {
throw "❌ Missing 'requires argument' error"
}
Write-Host "✅ Missing argument handling passed" -ForegroundColor Green
# ============ PROCESS NAME LOOKUP TESTS ============
- name: Test process name with svchost.exe
run: |
Write-Host "Testing process name lookup for svchost.exe..." -ForegroundColor Cyan
$output = ./win-witr.exe svchost.exe 2>&1 | Out-String
Write-Host $output
if ($output -match "Process Name specified") {
Write-Host "✅ Found svchost.exe" -ForegroundColor Green
} else {
Write-Host "⚠️ Unexpected output format" -ForegroundColor Yellow
}
- name: Test process name with explorer.exe
run: |
Write-Host "Testing process name lookup for explorer.exe..." -ForegroundColor Cyan
./win-witr.exe explorer.exe 2>&1 | Out-Null
Write-Host "✅ Explorer lookup completed" -ForegroundColor Green
- name: Test process name with non-existent process
run: |
Write-Host "Testing with non-existent process name..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
$output = cmd /c "win-witr.exe totallyFakeProcess.exe 2>&1"
$exitCode = $LASTEXITCODE
Write-Host ($output -join "`n")
if ($exitCode -eq 0) {
throw "❌ Should fail for non-existent process"
}
if (($output -join " ") -notmatch "Could not find process") {
throw "❌ Missing proper error message"
}
Write-Host "✅ Non-existent process handling passed" -ForegroundColor Green
# ============ OUTPUT FORMAT VALIDATION ============
- name: Validate PID output contains required fields
run: |
Write-Host "Validating output format..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
$requiredFields = @("Executable Path", "Process Ancestry", "Started")
foreach ($field in $requiredFields) {
if ($output -notmatch [regex]::Escape($field)) {
throw "❌ Output missing required field: $field"
}
}
Write-Host "✅ Output format validation passed" -ForegroundColor Green
- name: Test ancestry tree formatting
run: |
Write-Host "Testing ancestry tree formatting..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
# Check for tree-like structure
if ($output -match "PID") {
Write-Host "✅ Ancestry tree formatting passed" -ForegroundColor Green
} else {
throw "❌ Ancestry tree not properly formatted"
}
- name: Test timestamp format
run: |
Write-Host "Testing timestamp format..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
# Should contain "ago" and a date
if ($output -match "ago") {
Write-Host "✅ Timestamp format passed" -ForegroundColor Green
} else {
throw "❌ Timestamp format incorrect"
}
# ============ STRESS TESTS ============
- name: Rapid-fire stress test
run: |
Write-Host "Running stress test (50 rapid requests)..." -ForegroundColor Cyan
for ($i = 0; $i -lt 50; $i++) {
./win-witr.exe --pid $PID | Out-Null
if ($LASTEXITCODE -ne 0) {
throw "❌ Stress test failed at iteration $i"
}
}
Write-Host "✅ Stress test passed (50 iterations)" -ForegroundColor Green
- name: Test multiple running processes
run: |
Write-Host "Testing against multiple running processes..." -ForegroundColor Cyan
$processes = Get-Process | Where-Object { $_.Id -ne 0 -and $_.Id -ne 4 } | Select-Object -First 5
foreach ($proc in $processes) {
Write-Host " Testing PID $($proc.Id) ($($proc.Name))..."
./win-witr.exe --pid $proc.Id 2>&1 | Out-Null
}
Write-Host "✅ Multiple process test completed" -ForegroundColor Green
# ============ UNICODE HANDLING ============
- name: Test Unicode tree characters
run: |
Write-Host "Testing Unicode character handling..." -ForegroundColor Cyan
[Console]::OutputEncoding = [System.Text.Encoding]::UTF8
$output = ./win-witr.exe --pid $PID 2>&1 | Out-String
if ($LASTEXITCODE -ne 0) {
throw "❌ Unicode handling failed"
}
Write-Host "✅ Unicode test passed" -ForegroundColor Green
# ============ FINAL SUMMARY ============
- name: Test Summary
if: always()
run: |
Write-Host ""
Write-Host "========================================" -ForegroundColor Magenta
Write-Host " 🎉 RUNTIME TESTS COMPLETED! 🎉" -ForegroundColor Magenta
Write-Host "========================================" -ForegroundColor Magenta
Write-Host ""Key changes:
Now your CI will pass even when testing error conditions! 🎉 |
Owner
Author
|
@coderabbitai one extra thing 🥺🙏 can you make it post a nice comment on the pr (if it is on a pr, if its just on a commit... well it can't do crap) how can we make the comments a little smarter though... |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 11180 @supervoidcoder Absolutely! I'll add a fancy PR comment feature with a nice summary table! 🎯 Here's your updated workflow that posts a beautiful summary comment on PRs: name: Runtime Tests
on:
push:
branches: [ main, master ]
pull_request:
branches: [ main, master ]
jobs:
runtime-tests:
runs-on: windows-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@v1
- name: Initialize test results
run: |
@"
BUILD=⏳
HELP=⏳
VERSION=⏳
PID_TESTS=⏳
ERROR_HANDLING=⏳
PROCESS_LOOKUP=⏳
OUTPUT_VALIDATION=⏳
STRESS_TESTS=⏳
UNICODE=⏳
"@ | Out-File -FilePath test-results.txt
- name: Build win-witr
id: build
continue-on-error: true
run: |
cl.exe /EHsc /std:c++20 main.cpp /Fe:win-witr.exe advapi32.lib iphlpapi.lib ws2_32.lib shell32.lib /DUNICODE /D_UNICODE
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'BUILD=⏳', 'BUILD=❌' | Set-Content test-results.txt
throw "Build failed!"
}
(Get-Content test-results.txt) -replace 'BUILD=⏳', 'BUILD=✅' | Set-Content test-results.txt
# ============ HELP COMMAND TESTS ============
- name: Test help commands
id: help
continue-on-error: true
run: |
Write-Host "Testing --help flag..." -ForegroundColor Cyan
./win-witr.exe --help
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'HELP=⏳', 'HELP=❌' | Set-Content test-results.txt
throw "❌ Help command failed"
}
Write-Host "Testing -h flag..." -ForegroundColor Cyan
./win-witr.exe -h
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'HELP=⏳', 'HELP=❌' | Set-Content test-results.txt
throw "❌ Short help failed"
}
(Get-Content test-results.txt) -replace 'HELP=⏳', 'HELP=✅' | Set-Content test-results.txt
Write-Host "✅ Help tests passed" -ForegroundColor Green
# ============ VERSION COMMAND TESTS ============
- name: Test version commands
id: version
continue-on-error: true
run: |
Write-Host "Testing --version flag..." -ForegroundColor Cyan
$output = ./win-witr.exe --version | Out-String
Write-Host $output
if ($output -notmatch "win-witr v\d+\.\d+\.\d+") {
(Get-Content test-results.txt) -replace 'VERSION=⏳', 'VERSION=❌' | Set-Content test-results.txt
throw "❌ Version format incorrect: $output"
}
Write-Host "Testing -v flag..." -ForegroundColor Cyan
./win-witr.exe -v
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'VERSION=⏳', 'VERSION=❌' | Set-Content test-results.txt
throw "❌ Short version failed"
}
(Get-Content test-results.txt) -replace 'VERSION=⏳', 'VERSION=✅' | Set-Content test-results.txt
Write-Host "✅ Version tests passed" -ForegroundColor Green
# ============ PID INSPECTION TESTS ============
- name: Test PID inspection
id: pid
continue-on-error: true
run: |
Write-Host "Testing --pid 0 (System Idle)..." -ForegroundColor Cyan
./win-witr.exe --pid 0 2>&1 | Out-Null
Write-Host "Testing --pid 4 (System)..." -ForegroundColor Cyan
./win-witr.exe --pid 4 2>&1 | Out-Null
Write-Host "Testing --pid with current process ($PID)..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
Write-Host $output
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'PID_TESTS=⏳', 'PID_TESTS=❌' | Set-Content test-results.txt
throw "❌ Current process PID inspection failed"
}
if ($output -notmatch "Process Ancestry") {
(Get-Content test-results.txt) -replace 'PID_TESTS=⏳', 'PID_TESTS=❌' | Set-Content test-results.txt
throw "❌ Output missing 'Process Ancestry'"
}
Write-Host "Testing --pid with explorer.exe..." -ForegroundColor Cyan
$explorerPid = (Get-Process explorer -ErrorAction SilentlyContinue | Select-Object -First 1).Id
if ($explorerPid) {
Write-Host "Found explorer.exe with PID: $explorerPid"
./win-witr.exe --pid $explorerPid 2>&1 | Out-Null
}
(Get-Content test-results.txt) -replace 'PID_TESTS=⏳', 'PID_TESTS=✅' | Set-Content test-results.txt
Write-Host "✅ PID tests passed" -ForegroundColor Green
# ============ ERROR HANDLING TESTS ============
- name: Test error handling
id: errors
continue-on-error: true
run: |
Write-Host "Testing --pid with non-existent PID (99999)..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
cmd /c "win-witr.exe --pid 99999 2>&1" > $null
$exitCode = $LASTEXITCODE
if ($exitCode -eq 0) {
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=❌' | Set-Content test-results.txt
throw "❌ Should fail with non-existent PID"
}
Write-Host "Testing --pid with non-numeric argument..." -ForegroundColor Cyan
$output = cmd /c "win-witr.exe --pid notanumber 2>&1"
$exitCode = $LASTEXITCODE
if ($exitCode -eq 0) {
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=❌' | Set-Content test-results.txt
throw "❌ Should fail with non-numeric PID"
}
if (($output -join " ") -notmatch "not a valid number") {
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=❌' | Set-Content test-results.txt
throw "❌ Missing proper error message"
}
Write-Host "Testing --pid without argument..." -ForegroundColor Cyan
$output = cmd /c "win-witr.exe --pid 2>&1"
$exitCode = $LASTEXITCODE
if ($exitCode -eq 0) {
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=❌' | Set-Content test-results.txt
throw "❌ Should fail when --pid has no argument"
}
if (($output -join " ") -notmatch "requires an argument") {
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=❌' | Set-Content test-results.txt
throw "❌ Missing 'requires argument' error"
}
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=✅' | Set-Content test-results.txt
Write-Host "✅ Error handling tests passed" -ForegroundColor Green
# ============ PROCESS NAME LOOKUP TESTS ============
- name: Test process name lookup
id: lookup
continue-on-error: true
run: |
Write-Host "Testing process name lookup for svchost.exe..." -ForegroundColor Cyan
./win-witr.exe svchost.exe 2>&1 | Out-Null
Write-Host "Testing process name lookup for explorer.exe..." -ForegroundColor Cyan
./win-witr.exe explorer.exe 2>&1 | Out-Null
Write-Host "Testing with non-existent process name..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
$output = cmd /c "win-witr.exe totallyFakeProcess.exe 2>&1"
$exitCode = $LASTEXITCODE
if ($exitCode -eq 0) {
(Get-Content test-results.txt) -replace 'PROCESS_LOOKUP=⏳', 'PROCESS_LOOKUP=❌' | Set-Content test-results.txt
throw "❌ Should fail for non-existent process"
}
if (($output -join " ") -notmatch "Could not find process") {
(Get-Content test-results.txt) -replace 'PROCESS_LOOKUP=⏳', 'PROCESS_LOOKUP=❌' | Set-Content test-results.txt
throw "❌ Missing proper error message"
}
(Get-Content test-results.txt) -replace 'PROCESS_LOOKUP=⏳', 'PROCESS_LOOKUP=✅' | Set-Content test-results.txt
Write-Host "✅ Process lookup tests passed" -ForegroundColor Green
# ============ OUTPUT FORMAT VALIDATION ============
- name: Test output validation
id: output
continue-on-error: true
run: |
Write-Host "Validating output format..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
$requiredFields = @("Executable Path", "Process Ancestry", "Started")
foreach ($field in $requiredFields) {
if ($output -notmatch [regex]::Escape($field)) {
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=❌' | Set-Content test-results.txt
throw "❌ Output missing required field: $field"
}
}
Write-Host "Testing ancestry tree formatting..." -ForegroundColor Cyan
if ($output -notmatch "PID") {
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=❌' | Set-Content test-results.txt
throw "❌ Ancestry tree not properly formatted"
}
Write-Host "Testing timestamp format..." -ForegroundColor Cyan
if ($output -notmatch "ago") {
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=❌' | Set-Content test-results.txt
throw "❌ Timestamp format incorrect"
}
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=✅' | Set-Content test-results.txt
Write-Host "✅ Output validation passed" -ForegroundColor Green
# ============ STRESS TESTS ============
- name: Test stress and performance
id: stress
continue-on-error: true
run: |
Write-Host "Running stress test (50 rapid requests)..." -ForegroundColor Cyan
for ($i = 0; $i -lt 50; $i++) {
./win-witr.exe --pid $PID | Out-Null
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'STRESS_TESTS=⏳', 'STRESS_TESTS=❌' | Set-Content test-results.txt
throw "❌ Stress test failed at iteration $i"
}
}
Write-Host "Testing against multiple running processes..." -ForegroundColor Cyan
$processes = Get-Process | Where-Object { $_.Id -ne 0 -and $_.Id -ne 4 } | Select-Object -First 5
foreach ($proc in $processes) {
Write-Host " Testing PID $($proc.Id) ($($proc.Name))..."
./win-witr.exe --pid $proc.Id 2>&1 | Out-Null
}
(Get-Content test-results.txt) -replace 'STRESS_TESTS=⏳', 'STRESS_TESTS=✅' | Set-Content test-results.txt
Write-Host "✅ Stress tests passed (50 iterations)" -ForegroundColor Green
# ============ UNICODE HANDLING ============
- name: Test Unicode handling
id: unicode
continue-on-error: true
run: |
Write-Host "Testing Unicode character handling..." -ForegroundColor Cyan
[Console]::OutputEncoding = [System.Text.Encoding]::UTF8
$output = ./win-witr.exe --pid $PID 2>&1 | Out-String
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'UNICODE=⏳', 'UNICODE=❌' | Set-Content test-results.txt
throw "❌ Unicode handling failed"
}
(Get-Content test-results.txt) -replace 'UNICODE=⏳', 'UNICODE=✅' | Set-Content test-results.txt
Write-Host "✅ Unicode test passed" -ForegroundColor Green
# ============ FINAL SUMMARY ============
- name: Display summary
if: always()
run: |
Write-Host ""
Write-Host "========================================" -ForegroundColor Magenta
Write-Host " 🎉 RUNTIME TESTS COMPLETED! 🎉" -ForegroundColor Magenta
Write-Host "========================================" -ForegroundColor Magenta
Get-Content test-results.txt
Write-Host ""
# ============ POST PR COMMENT ============
- name: Post PR comment with results
if: github.event_name == 'pull_request' && always()
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
$results = Get-Content test-results.txt | ConvertFrom-StringData
$allPassed = $true
foreach ($value in $results.Values) {
if ($value -ne '✅') {
$allPassed = $false
break
}
}
$emoji = if ($allPassed) { '🎉' } else { '⚠️' }
$status = if ($allPassed) { 'All Tests Passed!' } else { 'Some Tests Failed' }
$comment = @"
## $emoji Runtime Tests Report
**Status:** $status
**Run:** [#${{ github.run_number }}](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
| Test Category | Result |
|---------------|--------|
| 🔨 Build | $($results.BUILD) |
| 📖 Help Commands | $($results.HELP) |
| 🏷️ Version Commands | $($results.VERSION) |
| 🔍 PID Inspection | $($results.PID_TESTS) |
| ⚠️ Error Handling | $($results.ERROR_HANDLING) |
| 🔎 Process Lookup | $($results.PROCESS_LOOKUP) |
| ✏️ Output Validation | $($results.OUTPUT_VALIDATION) |
| 🚀 Stress Tests | $($results.STRESS_TESTS) |
| 🌐 Unicode Handling | $($results.UNICODE) |
---
<sub>🤖 Automated test report by GitHub Actions</sub>
"@
$comment | Out-File -FilePath comment.txt -Encoding utf8
gh pr comment ${{ github.event.pull_request.number }} --body-file comment.txt
Write-Host "✅ Posted comment to PR #${{ github.event.pull_request.number }}" -ForegroundColor GreenWhat's new? 🎁
The comment will look like this on your PR:
Pretty neat, right? 😎✨ |
…ontain permissions Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
| Test Category | Result |
|---|---|
| 🔨 Build | ✅ |
| 📖 Help Commands | ✅ |
| 🏷️ Version Commands | ✅ |
| 🔍 PID Inspection | ✅ |
| ❌ | |
| 🔎 Process Lookup | ❌ |
| ✏️ Output Validation | ✅ |
| 🚀 Stress Tests | ✅ |
| 🌐 Unicode Handling | ✅ |
🤖 Automated test report by GitHub Actions
Owner
Author
|
@coderabbitai look at comment:
|
| Test Category | Result |
|---|---|
| 🔨 Build | ✅ |
| 📖 Help Commands | ✅ |
| 🏷️ Version Commands | ✅ |
| 🔍 PID Inspection | ✅ |
| ❌ | |
| 🔎 Process Lookup | ❌ |
| ✏️ Output Validation | ✅ |
| 🚀 Stress Tests | ✅ |
| 🌐 Unicode Handling | ✅ |
🤖 Automated test report by GitHub Actions
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@supervoidcoder Ah, I see the issue! The problem is that the The fix: We need to remove the 🏁 Script executed: Length of output: 14253 @supervoidcoder Got it! The problem is that when the binary correctly fails (which is what we expect), the validation logic should just mark it as passed ✅, but if something goes wrong with the validation itself, we're throwing which causes the step to fail. The fix is simple: Remove the name: Runtime Tests
on:
push:
branches: [ main, master ]
pull_request:
branches: [ main, master ]
permissions:
contents: read
pull-requests: write
jobs:
runtime-tests:
runs-on: windows-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@v1
- name: Initialize test results
run: |
@"
BUILD=⏳
HELP=⏳
VERSION=⏳
PID_TESTS=⏳
ERROR_HANDLING=⏳
PROCESS_LOOKUP=⏳
OUTPUT_VALIDATION=⏳
STRESS_TESTS=⏳
UNICODE=⏳
"@ | Out-File -FilePath test-results.txt
- name: Build win-witr
id: build
continue-on-error: true
run: |
cl.exe /EHsc /std:c++20 main.cpp /Fe:win-witr.exe advapi32.lib iphlpapi.lib ws2_32.lib shell32.lib /DUNICODE /D_UNICODE
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'BUILD=⏳', 'BUILD=❌' | Set-Content test-results.txt
throw "Build failed!"
}
(Get-Content test-results.txt) -replace 'BUILD=⏳', 'BUILD=✅' | Set-Content test-results.txt
# ============ HELP COMMAND TESTS ============
- name: Test help commands
id: help
continue-on-error: true
run: |
Write-Host "Testing --help flag..." -ForegroundColor Cyan
./win-witr.exe --help
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'HELP=⏳', 'HELP=❌' | Set-Content test-results.txt
throw "❌ Help command failed"
}
Write-Host "Testing -h flag..." -ForegroundColor Cyan
./win-witr.exe -h
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'HELP=⏳', 'HELP=❌' | Set-Content test-results.txt
throw "❌ Short help failed"
}
(Get-Content test-results.txt) -replace 'HELP=⏳', 'HELP=✅' | Set-Content test-results.txt
Write-Host "✅ Help tests passed" -ForegroundColor Green
# ============ VERSION COMMAND TESTS ============
- name: Test version commands
id: version
continue-on-error: true
run: |
Write-Host "Testing --version flag..." -ForegroundColor Cyan
$output = ./win-witr.exe --version | Out-String
Write-Host $output
if ($output -notmatch "win-witr v\d+\.\d+\.\d+") {
(Get-Content test-results.txt) -replace 'VERSION=⏳', 'VERSION=❌' | Set-Content test-results.txt
throw "❌ Version format incorrect: $output"
}
Write-Host "Testing -v flag..." -ForegroundColor Cyan
./win-witr.exe -v
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'VERSION=⏳', 'VERSION=❌' | Set-Content test-results.txt
throw "❌ Short version failed"
}
(Get-Content test-results.txt) -replace 'VERSION=⏳', 'VERSION=✅' | Set-Content test-results.txt
Write-Host "✅ Version tests passed" -ForegroundColor Green
# ============ PID INSPECTION TESTS ============
- name: Test PID inspection
id: pid
continue-on-error: true
run: |
Write-Host "Testing --pid 0 (System Idle)..." -ForegroundColor Cyan
./win-witr.exe --pid 0 2>&1 | Out-Null
Write-Host "Testing --pid 4 (System)..." -ForegroundColor Cyan
./win-witr.exe --pid 4 2>&1 | Out-Null
Write-Host "Testing --pid with current process ($PID)..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
Write-Host $output
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'PID_TESTS=⏳', 'PID_TESTS=❌' | Set-Content test-results.txt
throw "❌ Current process PID inspection failed"
}
if ($output -notmatch "Process Ancestry") {
(Get-Content test-results.txt) -replace 'PID_TESTS=⏳', 'PID_TESTS=❌' | Set-Content test-results.txt
throw "❌ Output missing 'Process Ancestry'"
}
Write-Host "Testing --pid with explorer.exe..." -ForegroundColor Cyan
$explorerPid = (Get-Process explorer -ErrorAction SilentlyContinue | Select-Object -First 1).Id
if ($explorerPid) {
Write-Host "Found explorer.exe with PID: $explorerPid"
./win-witr.exe --pid $explorerPid 2>&1 | Out-Null
}
(Get-Content test-results.txt) -replace 'PID_TESTS=⏳', 'PID_TESTS=✅' | Set-Content test-results.txt
Write-Host "✅ PID tests passed" -ForegroundColor Green
# ============ ERROR HANDLING TESTS ============
- name: Test error handling
id: errors
continue-on-error: true
run: |
$failed = $false
Write-Host "Testing --pid with non-existent PID (99999)..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
$output = cmd /c "win-witr.exe --pid 99999 2>&1"
if ($LASTEXITCODE -eq 0) {
Write-Host "❌ Should fail with non-existent PID" -ForegroundColor Red
$failed = $true
} else {
Write-Host "✅ Correctly failed with non-existent PID" -ForegroundColor Green
}
Write-Host "Testing --pid with non-numeric argument..." -ForegroundColor Cyan
$output = cmd /c "win-witr.exe --pid notanumber 2>&1"
if ($LASTEXITCODE -eq 0) {
Write-Host "❌ Should fail with non-numeric PID" -ForegroundColor Red
$failed = $true
} elseif (($output -join " ") -notmatch "not a valid number") {
Write-Host "❌ Missing proper error message for non-numeric PID" -ForegroundColor Red
$failed = $true
} else {
Write-Host "✅ Correctly failed with non-numeric PID" -ForegroundColor Green
}
Write-Host "Testing --pid without argument..." -ForegroundColor Cyan
$output = cmd /c "win-witr.exe --pid 2>&1"
if ($LASTEXITCODE -eq 0) {
Write-Host "❌ Should fail when --pid has no argument" -ForegroundColor Red
$failed = $true
} elseif (($output -join " ") -notmatch "requires an argument") {
Write-Host "❌ Missing 'requires argument' error" -ForegroundColor Red
$failed = $true
} else {
Write-Host "✅ Correctly failed with missing argument" -ForegroundColor Green
}
if ($failed) {
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=❌' | Set-Content test-results.txt
Write-Host "❌ Error handling tests failed" -ForegroundColor Red
} else {
(Get-Content test-results.txt) -replace 'ERROR_HANDLING=⏳', 'ERROR_HANDLING=✅' | Set-Content test-results.txt
Write-Host "✅ Error handling tests passed" -ForegroundColor Green
}
# ============ PROCESS NAME LOOKUP TESTS ============
- name: Test process name lookup
id: lookup
continue-on-error: true
run: |
$failed = $false
Write-Host "Testing process name lookup for svchost.exe..." -ForegroundColor Cyan
./win-witr.exe svchost.exe 2>&1 | Out-Null
Write-Host "Testing process name lookup for explorer.exe..." -ForegroundColor Cyan
./win-witr.exe explorer.exe 2>&1 | Out-Null
Write-Host "Testing with non-existent process name..." -ForegroundColor Cyan
$ErrorActionPreference = 'Continue'
$output = cmd /c "win-witr.exe totallyFakeProcess.exe 2>&1"
if ($LASTEXITCODE -eq 0) {
Write-Host "❌ Should fail for non-existent process" -ForegroundColor Red
$failed = $true
} elseif (($output -join " ") -notmatch "Could not find process") {
Write-Host "❌ Missing proper error message for non-existent process" -ForegroundColor Red
$failed = $true
} else {
Write-Host "✅ Correctly failed with non-existent process" -ForegroundColor Green
}
if ($failed) {
(Get-Content test-results.txt) -replace 'PROCESS_LOOKUP=⏳', 'PROCESS_LOOKUP=❌' | Set-Content test-results.txt
Write-Host "❌ Process lookup tests failed" -ForegroundColor Red
} else {
(Get-Content test-results.txt) -replace 'PROCESS_LOOKUP=⏳', 'PROCESS_LOOKUP=✅' | Set-Content test-results.txt
Write-Host "✅ Process lookup tests passed" -ForegroundColor Green
}
# ============ OUTPUT FORMAT VALIDATION ============
- name: Test output validation
id: output
continue-on-error: true
run: |
Write-Host "Validating output format..." -ForegroundColor Cyan
$output = ./win-witr.exe --pid $PID | Out-String
$requiredFields = @("Executable Path", "Process Ancestry", "Started")
foreach ($field in $requiredFields) {
if ($output -notmatch [regex]::Escape($field)) {
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=❌' | Set-Content test-results.txt
throw "❌ Output missing required field: $field"
}
}
Write-Host "Testing ancestry tree formatting..." -ForegroundColor Cyan
if ($output -notmatch "PID") {
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=❌' | Set-Content test-results.txt
throw "❌ Ancestry tree not properly formatted"
}
Write-Host "Testing timestamp format..." -ForegroundColor Cyan
if ($output -notmatch "ago") {
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=❌' | Set-Content test-results.txt
throw "❌ Timestamp format incorrect"
}
(Get-Content test-results.txt) -replace 'OUTPUT_VALIDATION=⏳', 'OUTPUT_VALIDATION=✅' | Set-Content test-results.txt
Write-Host "✅ Output validation passed" -ForegroundColor Green
# ============ STRESS TESTS ============
- name: Test stress and performance
id: stress
continue-on-error: true
run: |
Write-Host "Running stress test (50 rapid requests)..." -ForegroundColor Cyan
for ($i = 0; $i -lt 50; $i++) {
./win-witr.exe --pid $PID | Out-Null
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'STRESS_TESTS=⏳', 'STRESS_TESTS=❌' | Set-Content test-results.txt
throw "❌ Stress test failed at iteration $i"
}
}
Write-Host "Testing against multiple running processes..." -ForegroundColor Cyan
$processes = Get-Process | Where-Object { $_.Id -ne 0 -and $_.Id -ne 4 } | Select-Object -First 5
foreach ($proc in $processes) {
Write-Host " Testing PID $($proc.Id) ($($proc.Name))..."
./win-witr.exe --pid $proc.Id 2>&1 | Out-Null
}
(Get-Content test-results.txt) -replace 'STRESS_TESTS=⏳', 'STRESS_TESTS=✅' | Set-Content test-results.txt
Write-Host "✅ Stress tests passed (50 iterations)" -ForegroundColor Green
# ============ UNICODE HANDLING ============
- name: Test Unicode handling
id: unicode
continue-on-error: true
run: |
Write-Host "Testing Unicode character handling..." -ForegroundColor Cyan
[Console]::OutputEncoding = [System.Text.Encoding]::UTF8
$output = ./win-witr.exe --pid $PID 2>&1 | Out-String
if ($LASTEXITCODE -ne 0) {
(Get-Content test-results.txt) -replace 'UNICODE=⏳', 'UNICODE=❌' | Set-Content test-results.txt
throw "❌ Unicode handling failed"
}
(Get-Content test-results.txt) -replace 'UNICODE=⏳', 'UNICODE=✅' | Set-Content test-results.txt
Write-Host "✅ Unicode test passed" -ForegroundColor Green
# ============ FINAL SUMMARY ============
- name: Display summary
if: always()
run: |
Write-Host ""
Write-Host "========================================" -ForegroundColor Magenta
Write-Host " 🎉 RUNTIME TESTS COMPLETED! 🎉" -ForegroundColor Magenta
Write-Host "========================================" -ForegroundColor Magenta
Get-Content test-results.txt
Write-Host ""
# ============ POST PR COMMENT ============
- name: Post PR comment with results
if: github.event_name == 'pull_request' && always()
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
$results = Get-Content test-results.txt | ConvertFrom-StringData
$allPassed = $true
foreach ($value in $results.Values) {
if ($value -ne '✅') {
$allPassed = $false
break
}
}
$emoji = if ($allPassed) { '🎉' } else { '⚠️' }
$status = if ($allPassed) { 'All Tests Passed!' } else { 'Some Tests Failed' }
$comment = @"
## $emoji Runtime Tests Report
**Status:** $status
**Run:** [#${{ github.run_number }}](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
| Test Category | Result |
|---------------|--------|
| 🔨 Build | $($results.BUILD) |
| 📖 Help Commands | $($results.HELP) |
| 🏷️ Version Commands | $($results.VERSION) |
| 🔍 PID Inspection | $($results.PID_TESTS) |
| ⚠️ Error Handling | $($results.ERROR_HANDLING) |
| 🔎 Process Lookup | $($results.PROCESS_LOOKUP) |
| ✏️ Output Validation | $($results.OUTPUT_VALIDATION) |
| 🚀 Stress Tests | $($results.STRESS_TESTS) |
| 🌐 Unicode Handling | $($results.UNICODE) |
---
<sub>🤖 Automated test report by GitHub Actions</sub>
"@
$comment | Out-File -FilePath comment.txt -Encoding utf8
gh pr comment ${{ github.event.pull_request.number }} --body-file comment.txt
Write-Host "✅ Posted comment to PR #${{ github.event.pull_request.number }}" -ForegroundColor GreenKey changes in the ERROR_HANDLING and PROCESS_LOOKUP sections:
Now your tests that are supposed to fail (like invalid PID) won't cause the CI to fail! The workflow will complete all tests and give you a nice summary. 🎉 |
|
| Test Category | Result |
|---|---|
| 🔨 Build | ✅ |
| 📖 Help Commands | ✅ |
| 🏷️ Version Commands | ✅ |
| 🔍 PID Inspection | ✅ |
| ❌ | |
| 🔎 Process Lookup | ❌ |
| ✏️ Output Validation | ✅ |
| 🚀 Stress Tests | ✅ |
| 🌐 Unicode Handling | ✅ |
🤖 Automated test report by GitHub Actions
Owner
Author
|
yknow what who cares |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.