[release-3.1] metal3: downstream cluster EIB example fixes#1086
Merged
hardys merged 1 commit intosuse-edge:release-3.1from Mar 23, 2026
Merged
[release-3.1] metal3: downstream cluster EIB example fixes#1086hardys merged 1 commit intosuse-edge:release-3.1from
hardys merged 1 commit intosuse-edge:release-3.1from
Conversation
ranjinimn
reviewed
Mar 17, 2026
| packages: | ||
| packageList: | ||
| - jq | ||
| sccRegistrationCode: $SCC_REGISTRATION_CODE |
Collaborator
There was a problem hiding this comment.
Should we add the indentation here ?
Suggested change
| sccRegistrationCode: $SCC_REGISTRATION_CODE | |
| - $USERKEY1 | |
| createHomeDir: true | |
| packages: | |
| packageList: | |
| - jq | |
| sccRegistrationCode: $SCC_REGISTRATION_CODE |
or should I rebase once this PR is merged?
Contributor
Author
There was a problem hiding this comment.
To preserve the history it's best to merge this, then rebase your PR if that's OK for you?
ranjinimn
previously approved these changes
Mar 17, 2026
Collaborator
|
Sure @hardys But is it failing because of the workflow issue? |
Ensure jq is installed as it's needed for the manifest rke2-preinstall.service Also ensure transactional-update timers are disabled since we won't be doing package based updates. Fixes: suse-edge#394 Fixes: suse-edge#471 (cherry picked from commit 82f3de7)
Contributor
Author
Sorry for the slow response - it was a mistake with conflict resolution on my cherry-pick, should now be resolved! |
ranjinimn
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #509
Ensure jq is installed as it's needed for the manifest rke2-preinstall.service
Also ensure transactional-update timers are disabled since we won't be doing package based updates.
Fixes: #394
Fixes: #471
(cherry picked from commit 82f3de7)