feat(cli): Create & add one go #695
Conversation
🦋 Changeset detectedLatest commit: e66e861 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hello @kizivat do you want to puch forward this PR? or should I try to bring it to the finish line ? :) |
commit: |
|
I'm not sure why |
| // add verifications and inter-addon deps | ||
|
|
||
| // add inter-addon dependencies |
|
|
||
| const setups = selectedAddons.map(({ addon }) => addon); | ||
| const setupResult = setupAddons(setups, workspace)[addon.id]; | ||
| workspace = virtualWorkspace || (await createWorkspace({ ...workspace })); |
There was a problem hiding this comment.
not sure this is the right call here. Previously we createWorkspace after every run, so that if tailwind and vitest run (after each other), the vitest run should already know via the workspace that tailwind is already installed.
Or am I missing something here?
There was a problem hiding this comment.
Actually not sure why that works, but that seems to work
| addonSetupResults?: Record<string, AddonSetupResult>; | ||
| virtualWorkspace?: Workspace<any>; | ||
| }): Promise<{ nextSteps: string[]; packageManager?: AgentName | null }> { | ||
| let workspace = virtualWorkspace || (await createWorkspace({ cwd: options.cwd })); |
There was a problem hiding this comment.
Same as above? in which case would virtualWorkspace even be undefined? Couldnt we just do this check once and make sure it's not undefined later on.
There was a problem hiding this comment.
You are 100% right!
I will refactor this later 👍
3 participants
This should resolve #689 .
--addvariadic option tocreateenabling specifying add-ons during project creationPoint 1. is solved by separating the question prompting and applying add-ons in the
addscript. Both are reused in thecreateaction handler.I'm creating this as a draft PR to receive general direction before solving
// TODO_ONE:s.