This repository was archived by the owner on Feb 15, 2023. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 803
Add netlify deployment instructions #162
          
     Open
      
      
            josewhitetower
  wants to merge
  4
  commits into
  sveltejs:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
josewhitetower:patch-2
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    benmccann
  
              
              reviewed
              
                  
                    Aug 19, 2020 
                  
              
              
            
            
              
                    benmccann
  
              
              reviewed
              
                  
                    Aug 19, 2020 
                  
              
              
            
            
              
                    benmccann
  
              
              reviewed
              
                  
                    Aug 19, 2020 
                  
              
              
            
            
              
                    benmccann
  
              
              reviewed
              
                  
                    Aug 19, 2020 
                  
              
              
            
            
After some research I've found that there is a netlify-cli. Following the vercel and surge instructions way.
              
                    maxcell
  
              
              reviewed
              
                  
                    Nov 8, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want give ya a major shoutout @josewhitetower! I was coming by to do this contribution today and it was great to see it already here.
      Comment on lines
    
      +116
     to 
      +120
    
  
  | ```bash | ||
| netlify deploy --prod | ||
| ``` | ||
|  | ||
| Follow the instructions and be sure to set `public` as Publish Directory. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this callout for making sure to select the public directory because I totally didn't catch it myself when I tried to deploy so I know this is helpful!
It looks like the CLI added a flag to use instead too, so we can update the command to:
netlify deploy --dir=public --prodand leave the rest to "Follow the rest of the setup instructions"
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
No description provided.