Skip to content

Debug bench regressions #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: mmbm-benchmark-new-string-parsing
Choose a base branch
from
Open

Debug bench regressions #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
09fa7ab
Update benchmark thresholds + minor refinements (#1)
MahdiBM Oct 6, 2025
e4bfc8c
MISC minor refinements
MahdiBM Oct 8, 2025
bb5b83d
README refinements and sync with code changes
MahdiBM Oct 8, 2025
e737c87
More minor refinements
MahdiBM Oct 8, 2025
7601b05
Some updates and refinements
MahdiBM Oct 10, 2025
357486f
Lower down all availability reqs to macOS 15 + many more refinements
MahdiBM Oct 10, 2025
8000444
Update of benchmark thresholds with the new baselines
github-actions[bot] Oct 11, 2025
9279dca
Merge remote-tracking branch 'origin/auto-thr-update/main'
MahdiBM Oct 11, 2025
b41098e
Improve README
MahdiBM Oct 12, 2025
25c7a1d
Safer memory bindings
MahdiBM Oct 12, 2025
b984644
Update of benchmark thresholds with the deviated baseline
github-actions[bot] Oct 12, 2025
169e4ef
More accurate domain name implementation
MahdiBM Oct 13, 2025
86f0fda
General refinements
MahdiBM Oct 13, 2025
7869c83
Update of benchmark thresholds with the deviated baseline
github-actions[bot] Oct 13, 2025
109240e
Fix IPv4 -> DomainName conversion + other minor refinements
MahdiBM Oct 13, 2025
c5f0269
Update of benchmark thresholds with the deviated baseline
github-actions[bot] Oct 13, 2025
91e5fa9
Update of benchmark thresholds with the deviated baseline
github-actions[bot] Oct 13, 2025
aa33444
Merge branch 'mmbm-benchmark-new-string-parsing' into mmbm-debug-benchs
MahdiBM Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nightly-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
swift-image:
- name: swiftlang/swift:nightly-main-jammy
- name: swiftlang/swift:nightly-6.2-jammy
config:
- mode: "debug"
- mode: "release"
Expand Down
6 changes: 3 additions & 3 deletions Benchmarks/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Benchmarks/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ let package = Package(
.default(enabledTraits: ["IDNA_SUPPORT", "NIO_BYTE_BUFFER_SUPPORT"]),
],
dependencies: [
.package(url: "https://github.com/mahdibm/swift-idna.git", from: "1.0.0-beta.7"),
.package(url: "https://github.com/mahdibm/swift-idna.git", from: "1.0.0-beta.14"),
.package(url: "https://github.com/apple/swift-nio.git", from: "2.82.0"),
],
targets: [
Expand Down Expand Up @@ -88,13 +88,13 @@ var settings: [SwiftSetting] {
.enableUpcomingFeature("ExistentialAny"),
.enableUpcomingFeature("StrictMemorySafety"),
.enableExperimentalFeature(
"AvailabilityMacro=endpointApplePlatforms 26:macOS 26, iOS 26, tvOS 26, watchOS 26, visionOS 26"
"AvailabilityMacro=swiftEndpointApplePlatforms 26:macOS 26, iOS 26, tvOS 26, watchOS 26, visionOS 26"
),
.enableExperimentalFeature(
"AvailabilityMacro=endpointApplePlatforms 15:macOS 15, iOS 18, tvOS 18, watchOS 11, visionOS 2"
"AvailabilityMacro=swiftEndpointApplePlatforms 15:macOS 15, iOS 18, tvOS 18, watchOS 11, visionOS 2"
),
.enableExperimentalFeature(
"AvailabilityMacro=endpointApplePlatforms 13:macOS 13, iOS 16, tvOS 16, watchOS 9"
"AvailabilityMacro=swiftEndpointApplePlatforms 13:macOS 13, iOS 16, tvOS 16, watchOS 9"
),
]
}
Expand Down
4 changes: 2 additions & 2 deletions ...resholds/DomainNameBenchs.app-analytics-services_dot_com_String_Parsing_CPU_200K.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 40009727,
"min": 30000000
"max": 30000000,
"min": 20004863
}
}
2 changes: 1 addition & 1 deletion ...Thresholds/DomainNameBenchs.app-analytics-services_dot_com_String_Parsing_Malloc.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal": 3
"mallocCountTotal": 2
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/DomainNameBenchs.google_dot_com_String_Parsing_CPU_200K.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 30015487,
"min": 30000000
"max": 30000000,
"min": 20000000
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv4_CIDR_Create_Then_Check_Is_Multicast_100M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 140115967,
"max": 140000000,
"min": 110034943
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Decoding_Local_Broadcast_10M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 200015871,
"min": 180000000
"max": 240000000,
"min": 210000000
}
}
2 changes: 1 addition & 1 deletion ...ks/Thresholds/IPAddressBenchs.IPv4_String_Decoding_Local_Broadcast_inet_pton_10M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 250000000,
"max": 240123903,
"min": 240000000
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Decoding_Localhost_10M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 150000000,
"min": 120000000
"max": 180092927,
"min": 160000000
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Decoding_Zero_10M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 120061951,
"min": 100007935
"max": 160000000,
"min": 140000000
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Encoding_Local_Broadcast_15M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 200015871,
"max": 200000000,
"min": 190000000
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Encoding_Localhost_15M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 190000000,
"max": 180092927,
"min": 180000000
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Encoding_Mixed_15M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 190000000,
"max": 200000000,
"min": 180000000
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Encoding_Mixed_inet_ntop_15M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 2000000000,
"max": 1640000000,
"min": 1530000000
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv4_String_Encoding_Zero_15M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 210000000,
"max": 180092927,
"min": 180000000
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv6_CIDR_Create_Then_Check_Is_Loopback_100M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 140115967,
"max": 140000000,
"min": 110034943
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv6_CIDR_Create_Then_Check_Is_Multicast_100M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 140115967,
"max": 120061951,
"min": 110034943
}
}
4 changes: 2 additions & 2 deletions ...olds/IPAddressBenchs.IPv6_String_Decoding_2_Groups_Compressed_At_The_Begining_3M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 150077439,
"min": 140000000
"max": 160038911,
"min": 150000000
}
}
4 changes: 2 additions & 2 deletions ...hresholds/IPAddressBenchs.IPv6_String_Decoding_2_Groups_Compressed_At_The_End_3M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 150077439,
"min": 140000000
"max": 160038911,
"min": 150000000
}
}
4 changes: 2 additions & 2 deletions ...ressBenchs.IPv6_String_Decoding_2_Groups_Compressed_In_The_Middle_No_Brackets_3M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 150000000,
"min": 140000000
"max": 160038911,
"min": 150000000
}
}
2 changes: 1 addition & 1 deletion ....IPv6_String_Decoding_2_Groups_Compressed_In_The_Middle_No_Brackets_inet_pton_3M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 100007935,
"max": 110000000,
"min": 100000000
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv6_String_Decoding_Localhost_Compressed_5M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 140115967,
"min": 140000000
"max": 180000000,
"min": 160000000
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv6_String_Decoding_Uncompressed_3M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 160038911,
"min": 150000000
"max": 170000383,
"min": 160000000
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv6_String_Decoding_Zero_Compressed_5M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 150000000,
"min": 130000000
"max": 170000383,
"min": 150077439
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv6_String_Decoding_Zero_Uncompressed_3M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 160000000,
"min": 140115967
"max": 170000000,
"min": 150077439
}
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/IPAddressBenchs.IPv6_String_Encoding_Max_4M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 220069887,
"max": 220000000,
"min": 210000000
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv6_String_Encoding_Mixed_inet_ntop_4M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 940000000,
"min": 810000000
"max": 860000000,
"min": 800000000
}
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/IPAddressBenchs.IPv6_String_Encoding_Zero_10M.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cpuUser": {
"max": 200000000,
"min": 180000000
"max": 200015871,
"min": 200000000
}
}
6 changes: 3 additions & 3 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ let package = Package(
.default(enabledTraits: ["IDNA_SUPPORT", "NIO_BYTE_BUFFER_SUPPORT"]),
],
dependencies: [
.package(url: "https://github.com/swift-dns/swift-idna.git", from: "1.0.0-beta.7"),
.package(url: "https://github.com/swift-dns/swift-idna.git", from: "1.0.0-beta.14"),
.package(url: "https://github.com/apple/swift-nio.git", from: "2.82.0"),
],
targets: [
Expand Down Expand Up @@ -86,13 +86,13 @@ var settings: [SwiftSetting] {
.enableUpcomingFeature("ExistentialAny"),
.enableUpcomingFeature("StrictMemorySafety"),
.enableExperimentalFeature(
"AvailabilityMacro=endpointApplePlatforms 26:macOS 26, iOS 26, tvOS 26, watchOS 26, visionOS 26"
"AvailabilityMacro=swiftEndpointApplePlatforms 26:macOS 26, iOS 26, tvOS 26, watchOS 26, visionOS 26"
),
.enableExperimentalFeature(
"AvailabilityMacro=endpointApplePlatforms 15:macOS 15, iOS 18, tvOS 18, watchOS 11, visionOS 2"
"AvailabilityMacro=swiftEndpointApplePlatforms 15:macOS 15, iOS 18, tvOS 18, watchOS 11, visionOS 2"
),
.enableExperimentalFeature(
"AvailabilityMacro=endpointApplePlatforms 13:macOS 13, iOS 16, tvOS 16, watchOS 9"
"AvailabilityMacro=swiftEndpointApplePlatforms 13:macOS 13, iOS 16, tvOS 16, watchOS 9"
),
]
}
Loading
Loading