Fix MinGW builds in CI #1522
Closed
Fix MinGW builds in CI #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
approved these changes
Oct 25, 2025
Contributor
woodfell
left a comment
woodfell
left a comment
There was a problem hiding this comment.
Didn't know we still had check here, I thought everything got moved to gtest
martin4861
approved these changes
Oct 27, 2025
Contributor
martin4861
left a comment
martin4861
left a comment
There was a problem hiding this comment.
I think, I am fine with this change (even though the Bazel build and the CMake build will now use different versions of check).
Once libcheck/check#364 is merged, then I can follow up on this topic and I could try to create a new version of check.
Still, the preferred solution would be to use gtest if possible.
|
Contributor
Author
|
No longer needed due to #1527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MinGW stages in CI changed from MinGW-W64 v12.2.0 to v15.2.0 some time within the past 5 weeks. This broke compilation of the
checksubmodule due to the issue described in libcheck/check#364. I have created a PR to try and get a fix merged in upstream. However, even if the fix is accepted upstream, it is not clear to me how we want to proceed forlibsbp, since the commit message in #1513 makes it sound as though a very specific version ofcheckneeds to be used (specifically https://github.com/swift-nav/check/tree/11970a7e112dfe243a2e68773f014687df2900e8) due to bazel compatibility reasons.I can think of a few possibilities:
libsbpthe latest upstream version ofcheck. But maybe this will cause some kind of incompatibility with bazel.checksubmodule pointer to point to thefix-mingwbranch in https://github.com/swift-nav/check). But again, this might cause some kind of incompatibility with bazel.API compatibility
Does this change introduce a API compatibility risk?
Possible issue with bazel, see above.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
Wait for feedback from @martin4861
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX