Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Conversation

@dmitry-tatarinov
Copy link

@dmitry-tatarinov
Copy link
Author

@adel-mamin @ljbade @jacobmcnamee Please, review.
NOTE: to pass all checks following PRs should be merged:
#588
swift-nav/libswiftnav#294

@dmitry-tatarinov dmitry-tatarinov changed the title WIP: L2C capability monitor L2C capability monitor Feb 11, 2016
void l2c_capability_get(u32 *l2c_cpbl)
{
chMtxLock(&l2c_capability_upd_mutex);
*l2c_cpbl = gps_l2c_sv_capability;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add check l2c_cpbl against NULL

@swiftnav-jenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/piksi_firmware_Pull_Requests/866/


int fd = cfs_open(L2C_FILE, CFS_WRITE);
if (fd != -1) {
if(cfs_write(fd,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flash writes from the decoder thread scare me a little bit. I don't know what the maximum write time is, but if we do this for several channels back to back it might cause the nav bit FIFOs to overrun. Right now the FIFOs are 32 nav bits per channel, which can be as little as 64ms for some encodings.

I think doing the writes directly can be ok as long as we're sure timing won't be violated, but a better option might be to set a flag and periodically write to flash from a background thread when necessary (assuming the write can be done in a way that doesn't block the decode thread).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobmcnamee Since all SVs send SV config data for whole constellation incoming L2C data is same from all channels. Current algorithm monitors changing L2C capability data, so if we update it from one channel it will not updated from others. Worst case is flash writing rate is once per 12.5 mins.

The functionality allows to obtain SV config data from L1CA nav message
@dmitry-tatarinov
Copy link
Author

#630 should be merged first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants